Fix body property of collision events and reflect CollisionEventsEnabled properly#752
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #750
Someone (me) somehow got the entities mixed up for the
bodyproperty of theOnCollisionStartandOnCollisionEndedevents. It is documented to be the body of the entity that hittrigger.target(), but it is in fact the body associated with thetrigger.target()itself. Yikes!Additionally, the
CollisionEventsEnabledtype doesn't reflectComponentand isn't registered. This breaks scenes.Solution
Fix
bodyto be the body of the entity that hittrigger.target(), and reflectComponentforCollisionEventsEnabled.This is critical enough that I'll make a 0.3.1 patch release with it soon.