Change ColliderParent to a ColliderOf relationship and rework ColliderHierarchyPlugin#671
Merged
Conversation
Jondolf
added a commit
that referenced
this pull request
Mar 24, 2025
# Objective Fixes #676. #671 changed the `ColliderParent` component to a `ColliderOf` relationship. Because Bevy does not normally allow relationships to point to their own entities, this required a partial manual implementation of the `Relationship` trait. However, I left the default `on_replace` implementation, which (as it turns out) panics if the target entity does not exist, which is possible when despawning an entity and the relationship points to itself. ## Solution Manually implement `on_replace` in a non-panicking way. Also replace some panicking uses of `remove` with `try_remove`. Ideally this would be fixed by Bevy allowing self-relationships though.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
ColliderParentshould be a relationship for robustness and semantics, and to take advantage of automatic source tracking for rigid bodies.The
ColliderHierarchyPluginalso currently deals with both attaching colliders to rigid bodies and managing transforms. This would be good to split into separate plugins.Solution
Rename
ColliderParenttoColliderOf, make it aRelationship, and add aRigidBodyColliderscomponent for theRelationshipTarget. Collider hierarchies are now managed via observers and hooks instead of systems.Note that
ColliderOfrequires a customRelationshipimplementation, because Bevy's default implementation does not allow relationships to point to themselves.I also split the
ColliderHierarchyPlugininto aColliderHierarchyPlugin(managesColliderOfrelationships) andColliderTransformPlugin(manages and propagates collider transforms).Migration Guide
ColliderParenthas been renamed toColliderOf, and it is now aRelationship.The transform management in
ColliderHierarchyPluginhas been extracted into a newColliderTransformPlugin. TheColliderHierarchyPluginno longer takes a schedule.