Skip to content

test mne_qt_browser, remove test warning for coverage#317

Merged
sappelhoff merged 7 commits intoautoreject:masterfrom
sappelhoff:fixci
Oct 12, 2023
Merged

test mne_qt_browser, remove test warning for coverage#317
sappelhoff merged 7 commits intoautoreject:masterfrom
sappelhoff:fixci

Conversation

@sappelhoff
Copy link
Copy Markdown
Collaborator

actual CI failure addressed upstream in MNE-Python:

this one just deals with a warning and with a skipped test.

@sappelhoff
Copy link
Copy Markdown
Collaborator Author

@larsoner

I wonder why I am getting:

ERROR autoreject/tests/test_viz.py::test_viz[qt] - qtpy.QtBindingsNotFoundError: No Qt bindings could be found

I just added mne_qt_browser to the test deps so that a certain test is actually run instead of skipped --> now I get the above error. Shouldn't QT bindings be automatically installed with mne_qt_browser?

@larsoner
Copy link
Copy Markdown
Collaborator

larsoner commented Oct 4, 2023

Shouldn't QT bindings be automatically installed with mne_qt_browser?

No because there are 4 choices and we shouldn't choose for you. PyQt6 is best in my opinion though

@sappelhoff sappelhoff enabled auto-merge (squash) October 11, 2023 15:44
@sappelhoff
Copy link
Copy Markdown
Collaborator Author

failing due to the current stable version of mne-qt-browser still using a deprecated method from mne.

Not sure what to do ... wait for a release? Or pin the dev version of mne-qt-browser?

cc @larsoner

@larsoner
Copy link
Copy Markdown
Collaborator

Feel free to vote yes in mne-tools/mne-qt-browser#207 and I can quickly cut a release, hopefully today

@sappelhoff
Copy link
Copy Markdown
Collaborator Author

We're getting this error now

Cannot connect to a valid display

for Ubuntu only 🤔

@larsoner I cannot seem to access the error logs from azure. Is there an org that you can invite me to using my Email: stefan.appelhoff [--at--] mailbox.org ?

@larsoner
Copy link
Copy Markdown
Collaborator

for Ubuntu only 🤔

For this I use (for all OSes):

https://github.com/mne-tools/mne-python/blob/c7c8a2919734963726cd2d04fa9e01002b7f843c/.github/workflows/tests.yml#L86-L89

@larsoner I cannot seem to access the error logs from azure. Is there an org that you can invite me to using my Email: stefan.appelhoff [--at--] mailbox.org ?

Yes in principle but really I think we should just rm azure-pipelines.yml and remove it from the required checks. Looks like it just runs stable and dev and we already do that on GHA. And it's harder to maintain... speaking of which, this is the error:

________________________ ERROR at setup of test_viz[qt] ________________________
autoreject/conftest.py:114: in browser_backend
    with use_browser_backend(backend_name) as backend:
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/contextlib.py:135: in __enter__
    return next(self.gen)
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/mne/viz/_figure.py:839: in use_browser_backend
    old_backend = set_browser_backend(backend_name)
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/mne/viz/_figure.py:774: in set_browser_backend
    _load_backend(backend_name)
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/mne/viz/_figure.py:651: in _load_backend
    from mne_qt_browser import _pg_figure as backend
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/mne_qt_browser/_pg_figure.py:46: in <module>
    from qtpy.QtGui import (
/opt/hostedtoolcache/Python/3.10.13/x64/lib/python3.10/site-packages/qtpy/QtGui.py:57: in <module>
    from PyQt6 import QtGui
E   ImportError: libEGL.so.1: cannot open shared object file: No such file or directory

You can get GL support on Windows easily on GHA using the setup-headless-action thing I linked to above. It's also possible on Azure but (again) more of a pain:

https://github.com/mne-tools/mne-python/blob/c7c8a2919734963726cd2d04fa9e01002b7f843c/azure-pipelines.yml#L270-L274

@sappelhoff
Copy link
Copy Markdown
Collaborator Author

ok, done -- thanks for the advice and let's see whether this passes now. :-)

@sappelhoff sappelhoff merged commit fbefba0 into autoreject:master Oct 12, 2023
@jasmainak
Copy link
Copy Markdown
Member

Thanks @sappelhoff !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI failures (linux, multiprocessing, pickle)

3 participants