Skip to content

Fix epochs plotter#155

Merged
agramfort merged 2 commits intoautoreject:masterfrom
jasmainak:fix_viz
Oct 6, 2019
Merged

Fix epochs plotter#155
agramfort merged 2 commits intoautoreject:masterfrom
jasmainak:fix_viz

Conversation

@jasmainak
Copy link
Copy Markdown
Member

closes #153

should be merged in conjunction with mne-tools/mne-python#6855

@jasmainak jasmainak force-pushed the fix_viz branch 3 times, most recently from cac61aa to b9e55a5 Compare October 3, 2019 20:26
@codecov-io
Copy link
Copy Markdown

Codecov Report

Merging #155 into master will decrease coverage by 0.13%.
The diff coverage is 87.5%.

@@            Coverage Diff             @@
##           master     #155      +/-   ##
==========================================
- Coverage   93.91%   93.77%   -0.14%     
==========================================
  Files          10       10              
  Lines        1199     1221      +22     
==========================================
+ Hits         1126     1145      +19     
- Misses         73       76       +3

@jasmainak jasmainak changed the title WIP fix epochs plotter Fix epochs plotter Oct 4, 2019
@jasmainak
Copy link
Copy Markdown
Member Author

@agramfort @larsoner the CIs pass here with my branch of the PR on mne-python

@jasmainak
Copy link
Copy Markdown
Member Author

CIs are happy @agramfort

@agramfort agramfort merged commit ce4debe into autoreject:master Oct 6, 2019
@davestanley
Copy link
Copy Markdown

davestanley commented Oct 8, 2019

This update produced an error for me - the plot_epochs function in my 0.19 build of MNE could not accept the epoch_colors argument. Trying to update using pip install -U mne didn't fix this.

Incase others encounter the same issue, I was able to fix by installing the latest version of master (e.g., pip install -U https://api.github.com/repos/mne-tools/mne-python/zipball/master)

@agramfort
Copy link
Copy Markdown
Collaborator

agramfort commented Oct 8, 2019 via email

jasmainak added a commit that referenced this pull request Nov 7, 2019
* FIX epochs plotting

* Use master of mne for now
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

autoreject import failing with mne python master

4 participants