Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #259 +/- ##
=======================================
Coverage 66.72% 66.72%
=======================================
Files 17 17
Lines 1665 1665
=======================================
Hits 1111 1111
Misses 554 554 Continue to review full report at Codecov.
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems there was some issue with
AssertAlmostEqualwill callround(np.ndarray), causing the issue thatType: np.ndarray has no __round__ method. Solution was just to unpack the single element arraysAlso fixes an issue where
ConfigSpace.util::generate_gridwas converting log uniforms from float to int withvec.astype(int)instead ofnp.round(vec), which cause occasional failures due to something like99.9999999being converted to99instead of100.