Skip to content

Fix bug introduced by #221: #240

Merged
mfeurer merged 4 commits intomasterfrom
fix_pcs_writing
Mar 7, 2022
Merged

Fix bug introduced by #221: #240
mfeurer merged 4 commits intomasterfrom
fix_pcs_writing

Conversation

@mfeurer
Copy link
Copy Markdown
Contributor

@mfeurer mfeurer commented Mar 2, 2022

now, PCS can be serialized again if no weight was given

@mfeurer mfeurer requested a review from eddiebergman March 2, 2022 13:37
@mfeurer
Copy link
Copy Markdown
Contributor Author

mfeurer commented Mar 2, 2022

CC @hvarfner

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2022

Codecov Report

Merging #240 (0b97897) into master (4cc7bde) will increase coverage by 4.64%.
The diff coverage is 100.00%.

❗ Current head 0b97897 differs from pull request most recent head 6044c01. Consider uploading reports for the commit 6044c01 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #240      +/-   ##
==========================================
+ Coverage   62.43%   67.07%   +4.64%     
==========================================
  Files          17       17              
  Lines        1637     1637              
==========================================
+ Hits         1022     1098      +76     
+ Misses        615      539      -76     
Impacted Files Coverage Δ
ConfigSpace/read_and_write/json.py 85.25% <100.00%> (ø)
ConfigSpace/read_and_write/pcs.py 85.53% <100.00%> (+19.42%) ⬆️
ConfigSpace/read_and_write/pcs_new.py 90.93% <100.00%> (+8.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cc7bde...6044c01. Read the comment docs.

Co-authored-by: Eddie Bergman <eddiebergmanhs@gmail.com>
@mfeurer mfeurer merged commit 0ec0e13 into master Mar 7, 2022
@mfeurer mfeurer deleted the fix_pcs_writing branch March 7, 2022 15:07
github-actions bot pushed a commit that referenced this pull request Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants