[BUGFIX] fix(handbrake): skip preset argument when empty#1689
Merged
microtechno9000 merged 3 commits intoautomatic-ripping-machine:mainfrom Feb 5, 2026
Merged
Conversation
HandBrakeCLI does not require a preset, so we should not pass an empty --preset argument when hb_preset is not configured. Fixes automatic-ripping-machine#1637
ImLunaHey
added a commit
to ImLunaHey/nixos-configs
that referenced
this pull request
Feb 5, 2026
Temporarily set HB_PRESET to 'CLI Default' to avoid empty preset error. Custom encoder args still fully control output quality. Revert once automatic-ripping-machine/automatic-ripping-machine#1689 merges.
microtechno9000
approved these changes
Feb 5, 2026
Collaborator
microtechno9000
left a comment
There was a problem hiding this comment.
Nice simple bugfix, thanks
|
096737a
into
automatic-ripping-machine:main
11 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HandBrakeCLI does not require a preset, so passing an empty
--presetargument whenhb_presetis not configured can cause issues.This fix adds a conditional check to only include the
--presetargument whenhb_presetis non-empty, allowing HandBrake to use its default settings or explicit arguments provided viahb_args.Changes
arm/ripper/handbrake.py: Added conditional check before appending preset argumentFixes #1637