[BUGFIX] Fix fedora (rootful) podman & docker support#512
Merged
microtechno9000 merged 5 commits intoautomatic-ripping-machine:mainfrom Mar 12, 2026
Merged
Conversation
Contributor
Author
|
Converted to draft after finding some issues when using the newest versions of ARM and a USB CDROM and still getting OTHER permission errors during mount in the ARM python scripts.
Investigating |
Contributor
Author
|
Investigated.
Marking as ready for review. |
6 tasks
Contributor
Author
|
This bugfix has now been working nicely for about 2 weeks in my own setup. |
microtechno9000
approved these changes
Mar 12, 2026
Collaborator
microtechno9000
left a comment
There was a problem hiding this comment.
approved, no GID conflict from what I can see. Ubuntu does not use gid 11 by default
microtechno9000
approved these changes
Mar 12, 2026
f5a5c91
into
automatic-ripping-machine:main
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When following the instructions for running in a docker container in the arm wiki, a typical Fedora user would run into a permission issue in the container.
This would not stop the container or have a clear error message. This permission issue would have 2 symptoms:
The root cause is a difference between a system default in Fedora and Ubuntu.
automatic-ripping-machine/scripts/installers/setup-docker.shcorrectly gives thearmuser on the host machine the groupcdrom.armuser the groupcdromcdromon ubuntu is24, while the GID for the same group is11on Fedora, meaning that thearmuser in practice does not receive the required permission to read the/dev/srxdevice on Fedora and downstream derivative distro host machines.I use emojis to guide your eyes to the essentials, but no LLM was used in writing this text.
Type of change
Should not require documentation beyond what is in the Dockerfile
How Has This Been Tested?
Simplest test is to check permissions on the /dev/sr0 device on a fedora machine. Before this change it would display as such:
After change it will display as so:
and ripping succeeded on a generic dvd.
Tests were run like this. make sure to fix your volume paths, notice the easy-to-miss
.period in config!Checklist:
My code follows the style guidelines of this project
There is a similar change for the ARCH derivative distros in the Dockerfile so I followed that example.
I have performed a self-review of my own code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have tested that my fix is effective or that my feature works
Changelog:
Include the details of changes made here
Logs
When logged into the container image with the root user on a Fedora machine and running the following command, the output is