docs(wish): canonical-pgserve-pm2-supervision G2 + G3 implementation history#99
Conversation
…history
The canonical-pgserve-pm2-supervision wish was authored 2026-04-30 and
the cohort table in HANDOFF marked Groups 2/3/4 as NOT-STARTED. Reading
origin/main as of 2026-05-09 shows the truth is different:
- **G2 substantially shipped** in `automagik-dev/genie`. The
`src/genie-commands/install.ts` header self-documents as "Wave 2 of
the canonical-pgserve-pm2-supervision wish (PR pgserve#55, Wave 1
= pgserve#57)". The pm2 service was renamed `genie-serve` → `Genie`
at v4.260507.2 (handled in code via `LEGACY_PM2_PROCESS_NAMES`).
Doctor checks landed under different names (`pgserve binary` +
`pgserve under pm2` vs wish-prescribed `pm2-supervision` +
`canonical-autopg`); same intent, different IDs.
`src/lib/pm2-args.js` (Decision 3) NOT landed in genie — likely
inlined in install.ts; tracked as follow-up.
- **G3 partially shipped** in `automagik-dev/omni`.
`packages/cli/src/lib/canonical-pgserve.ts` exposes
`resolveCanonicalPgservePreference`, consumed by
`commands/install.ts`. Migration helper file is not present under
the wish-prescribed name `migrate-from-embedded-pgserve.ts`. The
`canonical-connection-string` doctor check is not found by literal
grep — either renamed during implementation or still pending.
- **G4 unverifiable locally** — `namastexlabs/genie-configure` is
not under `/home/genie/workspace/repos/`; the three brain doc
files prescribed by G4 cannot be inspected from this audit.
This commit lands two `Implementation history (2026-05-09)` blocks
(one in G2, one in G3) at the end of each group section, immediately
before the `---` separator. Mirrors the docs-fix pattern from PR #97
(G2-5 spec drift fix on `autopg-distribution-cutover-finalize`) and
ab4d859 (G1 single-install.sh decision). Future readers see what
shipped vs what's still pending without having to cross-reference
HANDOFF + multiple repos.
No code changes. No acceptance criteria changes. Audit references
point at:
- /home/genie/workspace/agents/genie-pgserve/ENGINEER-AUDIT-CANONICAL-G2.md
- /home/genie/workspace/agents/genie-pgserve/ENGINEER-AUDIT-CANONICAL-G3.md
- /home/genie/workspace/agents/genie-pgserve/ENGINEER-AUDIT-CANONICAL-G4.md
The cross-cutting CRITICAL (HANDOFF table cohort-row corrections) was
already actioned by genie-pgserve in a separate update; this commit
synchronizes the wish text with the corrected truth.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Code Review
This pull request updates the WISH.md documentation to include detailed implementation history for Groups 2 and 3 of the canonical-pgserve-pm2-supervision wish. The changes document the current shipping status for the genie and omni repositories, highlighting discrepancies in naming, missing components, and pending integration tests as identified in recent audits. No review comments were provided for this pull request, so I have no feedback to offer.
…ry (genie-configure brain files) Mirrors PR #99 (G2 + G3 implementation-history blocks) and ab4d859 (G1 docs-fix). Records the truth that G4's three brain deliverables shipped to namastexlabs/genie-configure during the original 2026-04-30 sprint, but the wish text never updated to reflect it. Verified by cloning namastexlabs/genie-configure during T11: - brain/Configuration & Routing/canonical-pgserve-pm2.md (230 lines) - brain/Runbooks/recover-pm2-stack.md (246 lines) - brain/_decisions/2026-04-30-canonical-pgserve.md (112 lines, ACCEPTED) Notable findings recorded in the new block: - **Filename rename** — 2 of 3 deliverables shipped under `canonical-pgserve-*` rather than the wish-prescribed `canonical-autopg-*`. Aligns with Decision #7 of the finalize wish (autopg + pgserve are interchangeable bin names) but the validation block in G4 still test-f's the wish-prescribed filenames and so fails against shipped state. Flagged for separate cleanup. - **No fixture for acceptance criterion 2** — "architecture map matches actual pm2 list" needs a recorded `pm2 list --json` fixture; today verification is human-eyeball. - **Brain ingestion is human-authored, not automated** — no @khal-os/brain imports observed in the cloned repo. The "ingestion" deliverable was fulfilled by manually authoring three Markdown files. Recording this so future contributors don't go looking for a missing automation pipeline. No code, no acceptance criteria changes, no validation block touched in this commit (the rename + validation cleanup is a separate follow-up task; this commit just records the truth so the next reader isn't blindsided). Audit trail: - /home/genie/workspace/agents/genie-pgserve/ENGINEER-AUDIT-CANONICAL-G4.md - HANDOFF cohort row already corrected by genie-pgserve in a separate update (G4 row flipped from UNVERIFIABLE LOCALLY to SHIPPED). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Summary
Mirrors the docs-fix pattern from PR #97 (G2-5 spec drift fix on
autopg-distribution-cutover-finalize): records the truth that the canonical-pgserve-pm2-supervision wish has substantially shipped while its HANDOFF row + wish text were stuck at 2026-04-30 "NOT-STARTED".Surfaced via T9 pre-flight audits (
ENGINEER-AUDIT-CANONICAL-G2.md/G3.md/G4.mdin the agent dir).Changes
.genie/wishes/canonical-pgserve-pm2-supervision/WISH.mdImplementation history (2026-05-09)blocks added at the end of Group 2 + Group 3 sections, immediately before the---separator. No code, no acceptance criteria changes.Diff: 4 insertions, 0 deletions.
What the new blocks record
G2 (genie install + pm2 supervision, Wave 2) — substantially shipped via
automagik-dev/genie:src/genie-commands/install.tsself-documents as Wave 2 of THIS wish (PR pgserve#55, Wave 1 = pgserve#57).genie-serve→Genieat v4.260507.2;LEGACY_PM2_PROCESS_NAMESdrives the in-place migration of operators on the older name.pgserve binary+pgserve under pm2(vspm2-supervision+canonical-autopg). Functional intent matches; the literal IDs differ.src/lib/pm2-args.jsshared lib) NOT yet landed in genie — pgserve'ssrc/lib/pm2-args.jsis canonical but genie has no copy. Constants likely inlined in install.ts. Tracked as follow-up.G3 (omni install reconfig + migration, Wave 3) — partially shipped via
automagik-dev/omni:packages/cli/src/lib/canonical-pgserve.tsexposesresolveCanonicalPgservePreference, consumed bycommands/install.ts.migrate-from-embedded-pgserve.ts— TBD whether renamed or pending.canonical-connection-stringdoctor check is not found by literal grep ofcommands/doctor.ts— either renamed during implementation or still pending.G4 (Brain ingestion + ADR, Wave 4) — unverifiable locally;
namastexlabs/genie-configureis not under/home/genie/workspace/repos/. No history block added for G4 in this PR.Why
Without these blocks, a future team-lead reading the wish text + HANDOFF row would dispatch a "build G2/G3 from scratch" team that re-implements work already merged in
automagik-dev/genie+automagik-dev/omni, generating merge collisions and wasted cycles. The cross-cutting CRITICAL from T9's audits flagged the HANDOFF cohort row separately; this PR synchronizes the wish text with the corrected truth.Out of scope
src/lib/pm2-args.jsin genie repo) — separate work.namastexlabs/genie-configurefor verification.Test plan
git diff --statconfirms 4 insertions, no other changes.---separators intact).🤖 Generated with Claude Code