Added remove file from recent opened files #260

saurabh-m-w · 2021-08-23T08:17:25Z

Fixes #260

CLAassistant · 2021-08-23T08:17:29Z

All committers have signed the CLA.

hpoul

thanks for the PR 👍️
do you think you could change that to be like a context menu - for example like the group list does it:

authpass/authpass/lib/ui/screens/group_list.dart

Lines 604 to 650 in 31e7341

    
           final action = await showDialog<GroupAction>( 
        
             context: context, 
        
             builder: (context) => SimpleDialog( 
        
               title: Text(group.name(loc)), 
        
               children: <Widget>[ 
        
                 if (!group.isOrInRecycleBin) ...[ 
        
                   SimpleDialogOption( 
        
                     onPressed: () => 
        
                         Navigator.of(context).pop(GroupAction.create), 
        
                     child: ListTile( 
        
                       leading: const Icon(Icons.create_new_folder), 
        
                       title: Text(loc.createSubgroup), 
        
                     ), 
        
                   ), 
        
                 ], 
        
                 SimpleDialogOption( 
        
                   onPressed: () => 
        
                       Navigator.of(context).pop(GroupAction.edit), 
        
                   child: ListTile( 
        
                     leading: const Icon(FontAwesomeIcons.edit), 
        
                     title: Text(loc.editAction), 
        
                   ), 
        
                 ), 
        
                 if (!group.isRoot && 
        
                     !group.isRecycleBin && 
        
                     !group.inRecycleBin) ...[ 
        
                   SimpleDialogOption( 
        
                     onPressed: () => 
        
                         Navigator.of(context).pop(GroupAction.delete), 
        
                     child: ListTile( 
        
                       leading: const Icon(Icons.delete), 
        
                       title: Text(loc.deleteAction), 
        
                     ), 
        
                   ), 
        
                 ], 
        
                 if (group.inRecycleBin) ...[ 
        
                   SimpleDialogOption( 
        
                       onPressed: () => Navigator.of(context) 
        
                           .pop(GroupAction.deletePermanently), 
        
                       child: ListTile( 
        
                         leading: const Icon(Icons.delete_forever), 
        
                         title: Text(loc.deletePermanentlyAction), 
        
                       )) 
        
                 ], 
        
               ], 
        
             ), 
        
           );

currently it would only show one option - something like "Remove from list". (I wouldn't call it "Remove recent file" because it does not remove/delete the file. It just hides it from the list.

thanks!

saurabh-m-w · 2021-08-23T15:00:49Z

hey @hpoul is that correct?

hpoul · 2021-08-23T16:42:38Z

Looks good! As long as it actually disappears from the list? 🤔️ Is it not refreshing?

I'm still thinking about the wording.. maybe we should call it literally "Hide from list", any thoughts?

saurabh-m-w · 2021-08-23T17:08:21Z

Looks good! As long as it actually disappears from the list? 🤔️ Is it not refreshing?

I'm still thinking about the wording.. maybe we should call it literally "Hide from list", any thoughts?

It is refreshing perfectly.
Yeah we can have like "Hide from list" ,
but after reopening that file , it will appear on recent list.
So is that you wanted or should we have to delete it from local storage ?

hpoul · 2021-08-23T17:59:15Z

for now I would just hide it once.. and that's it.. we can in a later step show a "Delete file" menu item next to it for local files. But lets first finish the "hide"

saurabh-m-w · 2021-08-24T05:28:10Z

for now I would just hide it once.. and that's it.. we can in a later step show a "Delete file" menu item next to it for local files. But lets first finish the "hide"

Yeah,check once updated screenshots.

hey @hpoul is that correct?

hpoul · 2021-08-24T06:45:47Z

yep, screenshots look good!

saurabh-m-w · 2021-08-24T11:07:17Z

hey I commited the code ,but what's the issue in checks?

hpoul · 2021-08-24T11:16:04Z

It looks like ./lib/ui/screens/select_file_screen.dart is not formatted correctly. make sure to use flutter format - see also https://flutter.dev/docs/development/tools/formatting
I personally simply use the "format on save" option from intellij/android studio.

Also make sure that flutter analyze returns no warnings. (Or check the Analyzer tool in android studio)

hpoul · 2021-08-25T12:20:53Z

great thanks.. I've just added CHANGELOG and changed the GestureDetector to an IconButton - Was there a reason for not using the IconButton? 🤔️
looks good, merging.

codecov · 2021-08-25T12:21:00Z

Codecov Report

Merging #260 (d48c04c) into master (e8e6b85) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff            @@
##           master    #260      +/-   ##
=========================================
- Coverage    2.12%   2.12%   -0.01%     
=========================================
  Files         105     105              
  Lines        9728    9750      +22     
=========================================
  Hits          207     207              
- Misses       9521    9543      +22

Impacted Files	Coverage Δ
authpass/lib/ui/screens/select_file_screen.dart	`0.17% <0.00%> (-0.01%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e8e6b85...d48c04c. Read the comment docs.

remove recent opened file

282c3ab

hpoul requested changes Aug 23, 2021

View reviewed changes

saurabh-m-w added 2 commits August 24, 2021 15:13

added context menu option to hide recent file

c6f5ea2

added context menu option to hide recent file

7303984

saurabh-m-w and others added 3 commits August 24, 2021 17:29

added context menu option to hide recent file

c1a271b

formatted correctly

efcee44

change GestureDetector to IconButton, add changelog.

d48c04c

hpoul approved these changes Aug 25, 2021

View reviewed changes

hpoul merged commit 648a75e into authpass:master Aug 25, 2021

This was referenced Aug 26, 2021

Improve handling of "internal" files #263

Open

Allow to remove files from the "recent files" list #186

Closed

Added ability to remove file from "Last Opened Files" list #227

Closed

	final action = await showDialog<GroupAction>(
	context: context,
	builder: (context) => SimpleDialog(
	title: Text(group.name(loc)),
	children: <Widget>[
	if (!group.isOrInRecycleBin) ...[
	SimpleDialogOption(
	onPressed: () =>
	Navigator.of(context).pop(GroupAction.create),
	child: ListTile(
	leading: const Icon(Icons.create_new_folder),
	title: Text(loc.createSubgroup),
	),
	),
	],
	SimpleDialogOption(
	onPressed: () =>
	Navigator.of(context).pop(GroupAction.edit),
	child: ListTile(
	leading: const Icon(FontAwesomeIcons.edit),
	title: Text(loc.editAction),
	),
	),
	if (!group.isRoot &&
	!group.isRecycleBin &&
	!group.inRecycleBin) ...[
	SimpleDialogOption(
	onPressed: () =>
	Navigator.of(context).pop(GroupAction.delete),
	child: ListTile(
	leading: const Icon(Icons.delete),
	title: Text(loc.deleteAction),
	),
	),
	],
	if (group.inRecycleBin) ...[
	SimpleDialogOption(
	onPressed: () => Navigator.of(context)
	.pop(GroupAction.deletePermanently),
	child: ListTile(
	leading: const Icon(Icons.delete_forever),
	title: Text(loc.deletePermanentlyAction),
	))
	],
	],
	),
	);

Uh oh!

Added remove file from recent opened files #260

Added remove file from recent opened files #260

Uh oh!

Conversation

saurabh-m-w commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

CLAassistant commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hpoul left a comment

Choose a reason for hiding this comment

Uh oh!

saurabh-m-w commented Aug 23, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hpoul commented Aug 23, 2021

Uh oh!

saurabh-m-w commented Aug 23, 2021

Uh oh!

hpoul commented Aug 23, 2021

Uh oh!

saurabh-m-w commented Aug 24, 2021

Uh oh!

hpoul commented Aug 24, 2021

Uh oh!

saurabh-m-w commented Aug 24, 2021

Uh oh!

hpoul commented Aug 24, 2021

Uh oh!

hpoul commented Aug 25, 2021

Uh oh!

codecov bot commented Aug 25, 2021

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

saurabh-m-w commented Aug 23, 2021 •

edited

Loading

CLAassistant commented Aug 23, 2021 •

edited

Loading

saurabh-m-w commented Aug 23, 2021 •

edited

Loading