Force use_strict during testing#577
Merged
ziluvatar merged 2 commits intoauth0:masterfrom Feb 20, 2019
Merged
Conversation
Contributor
|
Could you add some tests on |
Contributor
Author
|
@ziluvatar Done. Please check if it's what you had in mind. |
ziluvatar
approved these changes
Feb 20, 2019
Contributor
|
Thanks @lionello 👏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Our project was using JS strict mode and we got errors like
Enabling
--use_strictduring the mocha test revealed the culprit.