Refactor tests related to audience and aud#503
Merged
ziluvatar merged 1 commit intoauth0:masterfrom Jul 12, 2018
Merged
Conversation
This change extracts all tests in the existing test files related to audience and aud into a single test file. Several other tests are also added that were missing from the existing files.
Contributor
|
Nice, I'll merge it. What do you mean by:
I downloaded your branch and all references in tests are only your new file. |
Contributor
Author
|
The "should" was because I couldn't find any references with some simple searching of the existing tests. A more accurate statement would have been:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third PR for #492
This change extracts all tests in the existing test files related to
audienceandaudinto a single test file. Several other tests are also added that were missing from the existing files.I should have removed all references to
audienceandaudfrom the current test files.I did not add a full suite of tests for the validation on providing
audin the payload as there does not seem to be any validation. There is also limited tests for providing an array foraudience, as there is no additional validation on the array items. Both these issues could be handled with the next major release.As always, suggestions or missing tests are more than welcome!
Coverage Master
Coverage Branch