fix: captcha not rendering for initial signup screen in classic login #2677
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2677 +/- ##
==========================================
+ Coverage 42.54% 42.67% +0.12%
==========================================
Files 120 120
Lines 3145 3152 +7
Branches 337 338 +1
==========================================
+ Hits 1338 1345 +7
+ Misses 1713 1712 -1
- Partials 94 95 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ankita10119
approved these changes
Oct 3, 2025
Contributor
ankita10119
left a comment
There was a problem hiding this comment.
After testing and verifying the changes locally, these look good to me.
Contributor
|
@paebanks Please verify all your commits |
Merged
ankita10119
added a commit
that referenced
this pull request
Oct 21, 2025
**Added** - feat: add Claude Code PR Review workflow [\#2679](#2679) ([ankita10119](https://github.com/ankita10119)) **Fixed** - fix: captcha not rendering for initial signup screen in classic login [\#2677](#2677) ([paebanks](https://github.com/paebanks))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When a custom login page that uses Lock.js is initialized with the initialScreen: "signUp" value, we expect the Lock widget to render the signup prompt first. We also expect the initialization logic to render a CAPTCHA widget if a CAPTCHA is expected to be completed for signups.
The initialization does not render the CAPTCHA widget accordingly. The end-user might encounter an error if they submit the signup prompt without having solved a captcha.
References
Testing
Screenshots
Before fix: Captcha Required, but does not render when
initialScreenis set to 'signUp'After fix: Captcha required and is rendered when
initialScreenis set to 'signUp'Screen.Recording.2025-09-29.at.2.27.37.PM.mov
Screen.Recording.2025-09-29.at.1.40.48.PM.mov
Checklist