fix: Rename shop strategy #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@omarquazi-okta Could you please update the PR description with details of any testing performed—manual, automated, or otherwise—to help verify the changes? |
gyaneshgouraw-okta
approved these changes
Jul 11, 2025
Merged
gyaneshgouraw-okta
pushed a commit
that referenced
this pull request
Jul 28, 2025
**Added** - Add support for social connection Sign in with Shop [\#2602](#2602) ([reinisb](https://github.com/reinisb)) - fix: Rename shop strategy [\#2641](#2641) ([omarquazi-okta](https://github.com/omarquazi-okta)) **Fixes** - Fix Makefile for Puppeteer cache support [\#2625](#2625) ([ developerkunal](https://github.com/ developerkunal)) - chore: update .gitignore and Makefile for Puppeteer cache and config directories [\#2626](#2626) ([ developerkunal](https://github.com/ developerkunal)) - Fix Release PIPELINE [\#2627](#2627) ([ developerkunal](https://github.com/ developerkunal)) -Fix release pipeline cdn [\#2628](#2628) ([ developerkunal](https://github.com/ developerkunal)) --------- Co-authored-by: reinisb <reinis.babris@gmail.com> Co-authored-by: Kunal Dawar <35455566+developerkunal@users.noreply.github.com>
ankita10119
added a commit
that referenced
this pull request
Sep 12, 2025
### Changed - Bump karma from 6.4.3 to 6.4.4 - Bump pbkdf2 from 3.1.2 to 3.1.3 - Bump validator from 13.15.0 to 13.15.15 - Bump sha.js from 2.4.11 to 2.4.12 - Bump cipher-base from 1.0.4 to 1.0.6 - Bump codecov/codecov-action from 5.4.3 to 5.5.1 - Bump puppeteer from 24.9.0 to 24.19.0 - Bump tmp from 0.2.3 to 0.2.5 - bump fsevents to latest(SEC- 2161) - Bump eslint-plugin-react from 7.34.1 to 7.37.5 - Bump @grpc/grpc-js and @google-cloud/translate ### Fixed - Fix: social connection names not showing displayName correctly [\#2651](#2651) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Update old Twitter icon and name to "X" [\#2649](#2649) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Fix issue 2546 - TypeError: Super expression must either be null or a function [\#2578](#2578) ([Hworden](https://github.com/Hworden)) - Fix: Accessibility Issues #2624 [\#2642](#2642) ([ankita10119](https://github.com/ankita10119)) - fix: Rename shop strategy [\#2641](#2641) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Fix release pipeline cdn [\#2628](#2628) ([developerkunal](https://github.com/developerkunal)) - Fix Release PIPELINE [\#2627](#2627) ([developerkunal](https://github.com/developerkunal)) - chore: update .gitignore and Makefile for Puppeteer cache and config directories [\#2626](#2626) ([developerkunal](https://github.com/developerkunal)) - Fix Makefile for Puppeteer cache support [\#2625](#2625) ([developerkunal](https://github.com/developerkunal)) ### Removed - chore(ci): Remove Semgrep GHA Workflow [\#2650](#2650) ([eduardoboronat-okta](https://github.com/eduardoboronat-okta)) ### Security - security: Remove vulnerable node-es-module-loader dependency (SEC-2160) [\#2629](#2629) ([harekrishnarai](https://github.com/harekrishnarai)) ### Testing <!-- Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors. --> * [ ] This change adds unit test coverage * [ ] This change adds integration test coverage * [ ] This change has been tested on the latest version of the platform/language ### Checklist * [x] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) * [x] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) * [x] All code quality tools/guidelines have been run/followed * [x] All relevant assets have been compiled
ankita10119
added a commit
that referenced
this pull request
Sep 12, 2025
### Changed - Bump karma from 6.4.3 to 6.4.4 - Bump pbkdf2 from 3.1.2 to 3.1.3 - Bump validator from 13.15.0 to 13.15.15 - Bump sha.js from 2.4.11 to 2.4.12 - Bump cipher-base from 1.0.4 to 1.0.6 - Bump codecov/codecov-action from 5.4.3 to 5.5.1 - Bump puppeteer from 24.9.0 to 24.19.0 - Bump tmp from 0.2.3 to 0.2.5 - bump fsevents to latest(SEC- 2161) - Bump eslint-plugin-react from 7.34.1 to 7.37.5 - Bump @grpc/grpc-js and @google-cloud/translate ### Fixed - Fix: social connection names not showing displayName correctly [\#2651](#2651) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Update old Twitter icon and name to "X" [\#2649](#2649) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Fix issue 2546 - TypeError: Super expression must either be null or a function [\#2578](#2578) ([Hworden](https://github.com/Hworden)) - Fix: Accessibility Issues #2624 [\#2642](#2642) ([ankita10119](https://github.com/ankita10119)) - fix: Rename shop strategy [\#2641](#2641) ([omarquazi-okta](https://github.com/omarquazi-okta)) - Fix release pipeline cdn [\#2628](#2628) ([developerkunal](https://github.com/developerkunal)) - Fix Release PIPELINE [\#2627](#2627) ([developerkunal](https://github.com/developerkunal)) - chore: update .gitignore and Makefile for Puppeteer cache and config directories [\#2626](#2626) ([developerkunal](https://github.com/developerkunal)) - Fix Makefile for Puppeteer cache support [\#2625](#2625) ([developerkunal](https://github.com/developerkunal)) ### Removed - chore(ci): Remove Semgrep GHA Workflow [\#2650](#2650) ([eduardoboronat-okta](https://github.com/eduardoboronat-okta)) ### Security - security: Remove vulnerable node-es-module-loader dependency (SEC-2160) [\#2629](#2629) ([harekrishnarai](https://github.com/harekrishnarai)) ### Testing <!-- Please describe how this can be tested by reviewers. Be specific about anything not tested and reasons why. If this library has unit and/or integration testing, tests should be added for new functionality and existing tests should complete without errors. --> * [ ] This change adds unit test coverage * [ ] This change adds integration test coverage * [ ] This change has been tested on the latest version of the platform/language ### Checklist * [x] I have read the [Auth0 general contribution guidelines](https://github.com/auth0/open-source-template/blob/master/GENERAL-CONTRIBUTING.md) * [x] I have read the [Auth0 Code of Conduct](https://github.com/auth0/open-source-template/blob/master/CODE-OF-CONDUCT.md) * [x] All code quality tools/guidelines have been run/followed * [x] All relevant assets have been compiled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This change renames the Shop strategy from
sign-in-with-shoptoshop.References
Testing
Manual testing was completed against a test space with the appropriate changes required to get the new
Shopstrategy working. During testing I pointed my localLock.jsbuild to test the new connection name is working correctly!Checklist
Screenshot