[IAMRISK-3539] Use signup classic endpoint for captcha #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a20c12e to
1035ca5
Compare
da99f30 to
e48c1fa
Compare
TSLarson
commented
Nov 5, 2024
| "blueimp-md5": "^2.19.0", | ||
| "classnames": "^2.3.2", | ||
| "dompurify": "^2.3.12", | ||
| "dompurify": "^2.5.4", |
Contributor
Author
There was a problem hiding this comment.
Upgrading due to snyk warnings
TSLarson
commented
Nov 5, 2024
| swap(updateEntity, 'lock', id, setScreen, 'forgotPassword', fields); | ||
| } else { | ||
| swapCaptcha(id, 'login', false, () => { | ||
| swapCaptcha(id, Flow.PASSWORD_RESET, false, () => { |
TSLarson
commented
Nov 5, 2024
| successFn: setCaptcha | ||
| }); | ||
|
|
||
| m = sync(m, 'passwordlessCaptcha', { |
Contributor
Author
There was a problem hiding this comment.
Moving this due to bug with Simple CAPTCHA
TSLarson
commented
Nov 5, 2024
| done(); | ||
| }); | ||
| }); | ||
| }, 1000); |
Contributor
Author
There was a problem hiding this comment.
1000 was the lowest number I was able to set the timeout to and have the tests reliably pass
nandan-bhat
approved these changes
Nov 7, 2024
Merged
gyaneshgouraw-okta
added a commit
that referenced
this pull request
Nov 12, 2024
**Added** - [IAMRISK-3539] Use signup classic endpoint for captcha [\#2587](#2587) ([TSLarson](https://github.com/TSLarson)) **Fixed** - [IAMRISK-3554] hcaptcha bug fix [\#2566](#2566) ([Treterten](https://github.com/Treterten)) **Security** - ci: changed the trigger from pull_request_target to pull_request for better security [\#2584](#2584) ([nandan-bhat](https://github.com/nandan-bhat)) - Update codeowner file with new GitHub team name [\#2572](#2572) ([stevenwong-okta](https://github.com/stevenwong-okta)) [IAMRISK-3539]: https://auth0team.atlassian.net/browse/IAMRISK-3539?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ [IAMRISK-3554]: https://auth0team.atlassian.net/browse/IAMRISK-3554?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
References
https://auth0team.atlassian.net/browse/IAMRISK-4032
https://auth0team.atlassian.net/browse/IAMRISK-4161
Testing
https://oktawiki.atlassian.net/wiki/spaces/IAMCA/pages/3113844770/Bot+Detection+Signup+Classic+UL+Testing+Documentation
Checklist