Skip to content

Conversation

@Treterten
Copy link
Contributor

@Treterten Treterten commented May 23, 2024

Changes

Updates swap code so that CAPTCHA gets swapped along with the form

References

Ticket 1
Ticket 2

Testing

This can be tested via layer0 by pulling down the changes and running through the instructions under DEVELOPMENT.md for Testing Lock locally through the Universal Login Page

  • This change adds unit test coverage N/A
  • This change adds integration test coverage N/A
  • This change has been tested on the latest version of the platform/language

Checklist

Video of Fix

Screen.Recording.2024-05-23.at.3.46.36.PM.mov

@codecov
Copy link

codecov bot commented May 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 42.13%. Comparing base (a847c14) to head (42e455e).
Report is 10 commits behind head on master.

Current head 42e455e differs from pull request most recent head 326dc51

Please upload reports for the commit 326dc51 to get more accurate results.

Files Patch % Lines
src/connection/database/actions.js 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2558      +/-   ##
==========================================
- Coverage   42.35%   42.13%   -0.22%     
==========================================
  Files         120      120              
  Lines        3081     3116      +35     
  Branches      335      335              
==========================================
+ Hits         1305     1313       +8     
- Misses       1682     1710      +28     
+ Partials       94       93       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandan-bhat
Copy link
Contributor

Hi @Treterten,

Can you add some tests for the changes made ? codecov checks aren't passing.

{
"name": "auth0-lock",
"version": "12.5.0",
"version": "12.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this please? We do not bump versions in feature PRs.

{
"name": "auth0-lock",
"version": "12.5.0",
"version": "12.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this please? We do not bump versions in feature PRs.

"": {
"name": "auth0-lock",
"version": "12.5.0",
"version": "12.5.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we revert this please? We do not bump versions in feature PRs.

nandan-bhat

This comment was marked as duplicate.

stevehobbsdev pushed a commit that referenced this pull request May 30, 2024
### Changes

Exactly the same as #2558 , but without package.json version bump.

---------

Co-authored-by: Tre Moore <tre.moore@okta.com>
Co-authored-by: Josh Cain <josh.cain@okta.com>
@nandan-bhat
Copy link
Contributor

Closing this pull request because another pull request containing the same changes has been merged into the master branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants