Remove setting from site option when deleting plugin#32
Remove setting from site option when deleting plugin#32audrasjb merged 1 commit intoaudrasjb:masterfrom
Conversation
|
Hi, |
Because that's how WP stores things in the It's possible to have more than 1 plugin in a single directory. any file with a plugin header directly within a directory will be treated as a separate plugin. For instance, create a directory, Although, you shouldn't do that and I think it's against the guidelines for plugins in the .org repo. The updater provides enough hooks that, theoretically, a premium plugin could be written that would allow each of those multiple plugins within the same directory to be updated separately. I only know of one such "multiple plugins in the same directory" in the wide...and it's used on .org!! |
|
BTW, this PR works great! Thanx for that @bookdude13! |
|
Works great, thanks! |
Thanks for the info, and glad to help! |
Avoid duplicate Updating... dialog
Fixes #29.
One thing I noticed in this is that we are tracking plugin settings based on the plugin file path, not the slug. Could that cause issues for plugins which change their file location? Not sure how common that would be, but I feel like the slug makes more sense as an id?