This repository was archived by the owner on Aug 12, 2019. It is now read-only.
Add telemetry consent opt-in welcome page#48
Merged
Conversation
This was referenced Aug 2, 2016
In case the pane is narrow
Contributor
|
How does it look for somebody that opens Atom for the first time? Is the "Telemetry Consent" inactive/hidden like:
I think that's fine. If you miss it, it will just show again next time without the Welcome and Guide. Added some small style tweaks, otherwise 👍 |
Contributor
Author
|
It's part of the reason I wanted to combine the Atom and Get to know Atom pages so we could do it side-by side. Three open would be too much. Until they've made a decision on the Telemetry Consent page it will open each time but won't record any telemetry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All parts are required for this to work correctly;