This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Enable stable and beta draft release creation on VSTS #17862
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e3b1b71 to
5f8bbe4
Compare
Contributor
Author
|
The work is almost done here, just need to test with a few more simulated release builds before merging! |
9fcf6d2 to
e366134
Compare
Contributor
Author
|
Merging this despite unrelated test flakes, planning to test-drive this for the upcoming release. |
daviwil
added a commit
that referenced
this pull request
Feb 11, 2019
Enable stable and beta draft release creation on VSTS
This was referenced May 14, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds logic to our VSTS release build definition to enable the creation of draft GitHub releases when successful builds are produced on release branches (those named
1.xx-releases).NOTE: This change will not be turned on by default until 32-bit Windows builds are being produced on VSTS. This PR just adds the necessary release automation so that it's ready once those builds are being produced.
Alternate Designs
Why Should This Be In Core?
This is a build script for Atom.
Benefits
Draft releases are now created automatically for every successful build on a release branch. This removes the need for an Atom developer to go manually create a draft release with a separate internal tool.
This change also sets the stage for performing the final publishing steps with VSTS in an automated way.
Possible Drawbacks
None that I can think of.
Verification Process
This is a screenshot of a draft release created as a result of this build:
Applicable Issues
None.
TODO