Skip to content
This repository was archived by the owner on Mar 3, 2023. It is now read-only.

Always round GPU layer dimensions to physical pixel boundaries#15372

Merged
nathansobo merged 1 commit intomasterfrom
as-ns-fractional-pixel-ratio-support
Aug 17, 2017
Merged

Always round GPU layer dimensions to physical pixel boundaries#15372
nathansobo merged 1 commit intomasterfrom
as-ns-fractional-pixel-ratio-support

Conversation

@as-cii
Copy link
Contributor

@as-cii as-cii commented Aug 17, 2017 •
edited by Ben3eeE
Loading

Fixes #13361
Fixes #15180
Fixes #15257
Fixes #14237
Fixes #14898
Fixes #12652
Fixes #13627

This ensure subpixel anti-aliasing works when window.devicePixelRatio is not an integer. Since subpixel anti-aliasing relies on the physical characteristics of the display, Chromium only enables it when rasterizing content that it knows will be aligned to a physical pixel boundary.

@50Wliu @ungb @Ben3eeE: can you give this a spin on Windows, please? We have tested it works correctly with 125% on Windows and by manually calling setZoomLevel on macOS in the console, but we'd like to make sure this is a holistic solution to the blurriness problem. Also, if you think this fixes more issues than the ones we have linked above, feel free to add them.

/cc: @atom/maintainers

🍐'd with @nathansobo.

Always round GPU layer dimensions to physical pixel boundaries
88a06f8 
This ensure subpixel anti-aliasing works when `window.devicePixelRatio`
is not an integer.

Signed-off-by: Nathan Sobo <nathan@github.com>
@ungb
Copy link
Contributor

ungb commented Aug 17, 2017

Taking a 👀

@winstliu
Copy link
Contributor

winstliu commented Aug 17, 2017

Building now!

@winstliu
Copy link
Contributor

winstliu commented Aug 17, 2017 •
edited
Loading

Everything looks 💯 at a 150% display setting.

After this PR I think the only elements that don't have subpixel antialiasing are the tabs and status bar 🎉.

@damieng damieng mentioned this pull request Aug 17, 2017
Closed
@ungb
Copy link
Contributor

ungb commented Aug 17, 2017

I noticed a slight blur before and saw that things are looking better after changing the display to 125% and 150% thanks @50Wliu for verifying as well! 👍 💯

@Ben3eeE
Copy link
Contributor

Ben3eeE commented Aug 17, 2017

❤️ 💯 👏 🚢 Amazing work @as-cii @nathansobo

I'll give this a quick test on Windows 7 tomorrow as well.

@nathansobo
Copy link
Contributor

nathansobo commented Aug 17, 2017

AppVeyor looks like it got stuck installing dependencies for the 32 bit build, which we don't even run tests on. Everything else was green. Merging.

@nathansobo nathansobo merged commit f41be89 into master Aug 17, 2017
@nathansobo nathansobo deleted the as-ns-fractional-pixel-ratio-support branch August 17, 2017 23:13
@winstliu winstliu mentioned this pull request Aug 18, 2017
Closed
@ghost
Copy link

ghost commented Aug 21, 2017

Any idea when this will be released in a stable build?

@lee-dohm
Copy link
Contributor

lee-dohm commented Aug 22, 2017

@yonimend We can't guarantee anything but this is currently slated to ship with v1.21.0.

@as-cii
Copy link
Contributor Author

as-cii commented Aug 22, 2017

This will be contained in the next hotfix releases, which should go out this week.

as-cii pushed a commit that referenced this pull request Aug 22, 2017
Merge pull request #15372 from atom/as-ns-fractional-pixel-ratio-support
eca697b 
Always round GPU layer dimensions to physical pixel boundaries
as-cii pushed a commit that referenced this pull request Aug 22, 2017
Merge pull request #15372 from atom/as-ns-fractional-pixel-ratio-support
6b99a3f 
Always round GPU layer dimensions to physical pixel boundaries
@pbarbiero pbarbiero mentioned this pull request Aug 23, 2017
Closed
1 task
@as-cii as-cii mentioned this pull request Sep 7, 2017
Closed
@ungb ungb mentioned this pull request Oct 10, 2017
Closed
@Ben3eeE Ben3eeE mentioned this pull request Feb 28, 2018
Closed
1 task
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.