This repository was archived by the owner on Mar 3, 2023. It is now read-only.
Preserve specificity when transforming atom-text-editor::shadow#13124
Merged
nathansobo merged 1 commit intomasterfrom Nov 2, 2016
Merged
Preserve specificity when transforming atom-text-editor::shadow#13124nathansobo merged 1 commit intomasterfrom
nathansobo merged 1 commit intomasterfrom
Conversation
Simply replace ::shadow with .editor to preserve the specificity of the transformed rule. This isn't beautiful, but it's the only way to guarantee that the styling transition is smooth enough to justify not bumping the major.
Contributor
|
So far I only know that When testing with version 0.3.0 (that has the |
Contributor
|
Code-wise this looks good to me. Thanks for the fix, @nathansobo! ✨ 🙇 |
Contributor
Author
|
@simurai this is probably because the transformed file is cached on your machine using the old strategy. |
simurai
added a commit
to atom/flight-manual.atom.io
that referenced
this pull request
Nov 2, 2016
That got added in atom/atom#13124
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simply replace ::shadow with .editor to preserve the specificity of the transformed rule. This isn't beautiful, but it's the only way to guarantee that the styling transition is smooth enough to justify not bumping the major.
It would be great if some people that had styling regressions due to specificity could give this build a spin and see if things would have been okay if we transformed this way.
Closes #13019
/cc @as-cii @atom/maintainers @abe33