Since Electron v1.4.1 ships with electron/electron#7209, I hope this PR will resolve #11692.

Observations from around 10 minutes of light usage:

NOTHING IS BLURRY ANYMORE!

I have beautiful subpixel antialiasing on everything, even the actual code for the first time ever* 💥. Fixes #12652, maybe #7261, #3869, #2833.

Scrollbars seem to disappear randomly. Haven't narrowed this down but I did notice one of my files didn't have a scrollbar.

* Just noticed that the tabs and mini-editors don't have subpixel AA, but that's super minor compared to before.

Ok, something else related to subpixel AA:
If I scroll all the way to the end of the file or use the scrollbar, I lose subpixel AA in the editor until I switch tabs.

Scrollbars seem to disappear randomly. Haven't narrowed this down but I did notice one of my files didn't have a scrollbar.

Have this happening with the vertical scrollbar on the TextEditor active when restoring session. In the case of split panes (I tried left/right) both TextEditors are missing vertical scrollbars.

1. Open Atom 1.12-dev-fcddf83 open some file that has content enough to have a vertical scrollbar.
2. Close Atom.
3. Open Atom 1.12-dev-fcddf83 and keep an eye on the vertical scrollbar. It appears quickly when opening the previous session and then disappears.

If you resize the pane so that the horizontal scrollbar appears or disappears then you can get the vertical scrollbar to appear, but in all other cases this file seems to be missing the vertical scrollbar.

Tested with both Atom Light and One Dark themes. This does not reproduce in 1.11-beta5. Don't know about other dev versions.

The disappearing scrollbar issue appears to happen on the first file that is opened/restored. From the dev tools, the scrollbar (and scrollbar corner) is being given a width of 10px instead of the usual 15px. If I change it to 15, then the scrollbar appears. Anything > 10 works. /cc @simurai
I've also been seeing a related issue where the scrollbar flickers like crazy when moving the mouse between the tab bar and the editor. I'll try to find a stable repro case for that, but it also happens on the first file.

Now, some more subpixel antialiasing updates. As I said before, it works for the most part. Here's when it fails:

1. In a mini-editor
2. (Almost) anywhere with rendered text (eg Settings View, Tabs, Notifications, About). The tree view and status bar are fine though?
3. Upon reaching the end of the file
4. Upon scrolling with a touchpad or scrollbar. Mousewheel scrolling is fine.
5. Upon editing the last three visible lines, causing the editor to scroll and triggering case 4).
6. Dev tools

Also, Atom occasionally crashes when I try to close it. I'm not sure if that is specific to the Electron upgrade though as it's happened before as well.

More comments.

I appear to lose subpixel antialiasing during any type of scrolling (programmatically through go-to-line or find-and-replace, for example, or manually) except for mousewheel scrolling.

The dev tools are frozen after reloading the window and must be closed through the keybinding and reopened in order for it to work.

Chrome tends to switch from sub-pixel to regular AA when it expects to need to redraw it several times such as in animation. This is because AA can be cached and re-used whereas sub-pixel depends on the horizontal offset.

The scrollbar issue is super weird. Changing the width to anything other than the original (10px) works.. but when changing bottom it alternates. See the sub-pixel (0.1px) steps.

It seems any property that triggers a layout reflow makes the scrollbar visibility alternate when changing the value:

And just typing in search + replace alternates the horizontal scrollbar:

ps. on macOS, this issue only happens if the "Show scroll bars" is set to "Always". Otherwise (where the scroll bars hide automatically) it's fine.

Another thing I noticed. The native tabs in macOS Sierra seem to work in this Electron version. Problem with the custom title bar is that the native tabs are just on top and don't push the rest down. Also, hard to read with dark themes.

Native title bar works fine.

Steps to reproduce:

1. Enable Atom Settings > Core > Use Custom Title Bar.
2. Switch macOS Prefereces > Dock > "Prefer tabs when opening documents" to "Always":
   
3. Open another window with cmd-o or View > Show Tab Bar.

Possible solution

a. Either disable native tabs when custom title bar is enabled.
b. See if it's possible to detect when native tabs get added and then push the content down.

Maybe not that urgent, since you have to enable two things to run into this. Could also be a separate issue.

Update:

Fixed with Electron v1.4.2.

@simurai Electron v1.4.2 disabled the native tabs support, so this shouldn't be an issue anymore 🎱

🙈 Drag image 🙈

electron 1.x is coming in atom 1.12?

How long before this change will be merged into the master?

I can't reproduce the find menu issue in safe mode, so it looks like that one was a false alarm.

@kaiser101 We're facing some hard crashes with Electron when the dev tools are open. We may merge anyway and figure it out on master though.

@steelbrain Unclear from your gif... Were you seeing lag scrolling the editor? If so, the lag could be due to longer pauses garbage collecting DOM nodes as we dropped the recycling strategy. @as-cii I wonder if we should revisit that. At some point we're gonna GC DOM and I worry those pauses could get long. It allocates quite a bit of memory. But first priority is these crashes I suppose.

@nathansobo The editor was scrolling perfectly, the lag was only visible when scrolling search-and-replace tab (there would be white spaces in screen that would be filled later)

@steelbrain That's definitely a find and replace bug and is worth reporting on that package if it hasn't been already.

Seems like AppVeyor failed but I believe that's just spurious. I will go ahead and merge it into master so that it can bake for a while before putting it on beta.

Thanks everyone for the help and the hard work on this! 🙏