Guard against missing remote function properties#7209
Merged
Conversation
kevinsawicki
commented
Sep 14, 2016
|
|
||
| return new Proxy(remoteMemberFunction, { | ||
| set: function(target, property, value, receiver) { | ||
| if (property !== 'ref') loadRemoteProperties() |
Contributor
Author
There was a problem hiding this comment.
This prevents eagerly loading the function properties when the function is accessed or invoked.
32b9780 to
eef4277
Compare
Contributor
|
👍 |
Contributor
|
👏 |
17 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A remote function that is no longer available when its properties are accessed will throws error when the member metadata is lazily loaded.
This pull request guards against this case and at least partially fixes #7196, specifically the
Cannot read property 'Symbol(Symbol.iterator)' of undefinederrors.