Add virtual IsEntity/IsLoaded interfaces for phpstan#932
Closed
Add virtual IsEntity/IsLoaded interfaces for phpstan#932
Conversation
1e1421a to
5ccefd5
Compare
46e71b7 to
697b354
Compare
697b354 to
b0b50a0
Compare
4675faf to
5c39296
Compare
5008738 to
7811b63
Compare
40b2a8b to
a401874
Compare
c4823a1 to
07aa230
Compare
8401037 to
40cf25a
Compare
40cf25a to
ed26dac
Compare
ed26dac to
eca3429
Compare
eca3429 to
35394da
Compare
35394da to
ce1fceb
Compare
Member
Author
|
there must be a better way to do it - phpstan/phpstan#12101 |
debug II test no static fix no th fix cs rm ex null
ce1fceb to
803695c
Compare
Member
Author
|
rebased from 1.x phpstan Hard to decide, but we should probably not fake an interface as at least for final classes, this might resolve to never. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
needs phpstan/phpstan#7344 (implemented)
needs phpstan/phpstan#7385 - https://phpstan.org/developing-extensions/type-specifying-extensions should be the workhorse
needs phpstan/phpstan#7386 (solution found)
TODO check if https://github.com/phpstan/phpstan-src/pull/2609/files can help