How to get object type from class string type? #7386

mvorisek · 2022-06-02T23:06:55Z

mvorisek
Jun 2, 2022

In a custom extension I need to create an object phpstan Type from the phpstan scope.

I figured out I can obtain the scope class string like:

$classNameType = $scope->getType(new ClassConstFetch($methodCall->class, 'class'));

but how can I create an object phpstan Type from it?

for constant string I figured out I can do:

$calledOnOrigType = new ObjectType($classNameType->getValue());

but if the $classNameType is instanceof PHPStan\Type\Generic\GenericClassStringType the getValue method obviously does not exist and the code fails

is there any helper method like Util::createObjectTypeFromClassStringType(PHPStan\Type\ClassStringType $classStringType)?

herndlm · 2022-06-03T04:36:34Z

herndlm
Jun 3, 2022

Sorry for not trying it out first, but GenericClassStringType has a getGenericType, is that helping? That might hold the object already, I'm not a 100% sure, but you'll figure out via debugger or so :)

1 reply

mvorisek Jun 3, 2022
Author

yes, this is the solution I figured out from the phpstan sources, but it is quite complicated:

    /**
     * @param MethodCall|StaticCall $methodCall
     */
    protected function getMethodCallScopeType(CallLike $methodCall, Scope $scope): Type
    {
        if ($methodCall instanceof StaticCall) {
            $classNameType = $scope->getType(new ClassConstFetch($methodCall->class, 'class'));
            if ($classNameType instanceof ConstantStringType) {
                return new ObjectType($classNameType->getValue());
            } elseif ($classNameType instanceof GenericClassStringType) {
                return $classNameType->getGenericType();
            }

            throw new \Exception('Unexpected scope class name class: ' . get_class($classNameType));
        }

        return $scope->getType($methodCall->var);
    }

and it would be great if we can have an util method for it

rvanvelzen · 2022-06-03T04:57:22Z

rvanvelzen
Jun 3, 2022

$objectType = $scope->getType($methodCall->class);

6 replies

rvanvelzen Jun 3, 2022

Ah, I didn't realize this was about static method calls. You can use $scope->resolveTypeByName($methodCall->class) in case it's a Name:

$objectType = $node->class instanceof Name ? $this->resolveTypeByName($node->class) : $this->getType($node->class);

mvorisek Jun 3, 2022
Author

This is the answer I was looking for, thank you ❤️

So now I use:

    /**
     * @param MethodCall|StaticCall $methodCall
     */
    protected function getMethodCallScopeType(CallLike $methodCall, Scope $scope): Type
    {
        if ($methodCall instanceof StaticCall) {
            return $methodCall->class instanceof Name
                ? $scope->resolveTypeByName($methodCall->class)
                : $scope->getType($methodCall->class);
        }

        return $scope->getType($methodCall->var);
    }

and it seems it cannot be further simplified.

mvorisek Jun 3, 2022
Author

it does not work on (static::class)::method() (resolveTypeByName must be called, but static::class is not instance of Name)

rvanvelzen Jun 3, 2022

You'll need some extra code to handle that, taken from MutatingScope:

    /**
     * @param MethodCall|StaticCall $methodCall
     */
    protected function getMethodCallScopeType(CallLike $methodCall, Scope $scope): Type
    {
        if ($methodCall instanceof StaticCall) {
            if ($methodCall->class instanceof Name) {
                return $this->resolveTypeByName($methodCall->class);
            }

            return TypeTraverser::map($this->getType($methodCall->class), static function (Type $type, callable $traverse): Type {
                if ($type instanceof UnionType) {
                    return $traverse($type);
                }

                if ($type instanceof GenericClassStringType) {
                    return $type->getGenericType();
                }

                if ($type instanceof ConstantStringType && $type->isClassString()) {
                    return new ObjectType($type->getValue());
                }

                return $type;
            });
        }

        return $scope->getType($methodCall->var);
    }

mvorisek Jun 18, 2022
Author

the solution is to use $scope->getType(new New_($methodCall->class))

Uh oh!

How to get object type from class string type? #7386

Uh oh!

Uh oh!

mvorisek Jun 2, 2022

Replies: 2 comments · 7 replies

Uh oh!

Uh oh!

herndlm Jun 3, 2022

Uh oh!

mvorisek Jun 3, 2022 Author

Uh oh!

rvanvelzen Jun 3, 2022

Uh oh!

rvanvelzen Jun 3, 2022

Uh oh!

mvorisek Jun 3, 2022 Author

Uh oh!

Uh oh!

mvorisek Jun 3, 2022 Author

Uh oh!

rvanvelzen Jun 3, 2022

Uh oh!

mvorisek Jun 18, 2022 Author

mvorisek
Jun 2, 2022

Replies: 2 comments 7 replies

herndlm
Jun 3, 2022

mvorisek Jun 3, 2022
Author

rvanvelzen
Jun 3, 2022

mvorisek Jun 3, 2022
Author

mvorisek Jun 3, 2022
Author

mvorisek Jun 18, 2022
Author