Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/clock
that referenced
this pull request
Jan 10, 2026
## Context `Time.monotonic` has been [deprecated](crystal-lang/rfcs#15) in Crystal stdlib. The new `Time.instant` API doesn't, for good reason, doesn't have any overlap with `Time`, thus making it somewhat incompatible with `ACLK::Interface`. Instead of trying to hack in some solution using `Time.instant`, this PR just removes the monotonic clock. If/when there is a usecase that comes up that would benefit from it. We could explore our options at that point. ## Changelog - Remove `ACLK::Monotonic` - Update `console` usages to use `ACLK::Native`
PallasAthenaie
pushed a commit
to athena-framework/console
that referenced
this pull request
Jan 10, 2026
## Context `Time.monotonic` has been [deprecated](crystal-lang/rfcs#15) in Crystal stdlib. The new `Time.instant` API doesn't, for good reason, doesn't have any overlap with `Time`, thus making it somewhat incompatible with `ACLK::Interface`. Instead of trying to hack in some solution using `Time.instant`, this PR just removes the monotonic clock. If/when there is a usecase that comes up that would benefit from it. We could explore our options at that point. ## Changelog - Remove `ACLK::Monotonic` - Update `console` usages to use `ACLK::Native`
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Time.monotonichas been deprecated in Crystal stdlib. The newTime.instantAPI doesn't, for good reason, doesn't have any overlap withTime, thus making it somewhat incompatible withACLK::Interface. Instead of trying to hack in some solution usingTime.instant, this PR just removes the monotonic clock.If/when there is a usecase that comes up that would benefit from it. We could explore our options at that point.
Changelog
ACLK::Monotonicconsoleusages to useACLK::NativeBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title