Handle nested style tags #568
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Not sure why we're not getting a coverage report. Their UI says:
But the action logs https://github.com/athena-framework/athena/actions/runs/16709017393/job/47291188720#step:11:416 say it was successful. Maybe they're just backed up atm? 🤷. |
Codecov Report✅ All modified and coverable lines are covered by tests.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/console
that referenced
this pull request
Aug 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Refactors
ACON::Formatter::OutputStyleto not delegate to stdlib'sColorizemodule for now. If/when crystal-lang/crystal#16052 is merged/released we can go back to leveraging it. But for now, this PR gives the same benefit w/o having to wait for the next release.This change allows for leveraging nested style tags, E.g.
Would previously render as:
But now correctly renders as:
(Second one just so happened to work in both cases)
Supersedes #567, something got messed up with it and codecov.
Changelog
Before merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title