Skip to content

Add AVD::Spec::CompoundConstraintTestCase#540

Merged
Blacksmoke16 merged 3 commits intomasterfrom
compound-constraint-test-case
May 20, 2025
Merged

Add AVD::Spec::CompoundConstraintTestCase#540
Blacksmoke16 merged 3 commits intomasterfrom
compound-constraint-test-case

Conversation

@Blacksmoke16
Copy link
Member

Context

Compound constraints are useful, but previously were quite hard to test. This PR introduces a new abstract test case specifically suited to testing them.

Changelog

  • Add AVD::Spec::CompoundConstraintTestCase
  • Fix equality between AVD::Constraint instances

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@codecov
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 97.10145% with 2 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...alidator/src/spec/compound_constraint_test_case.cr 93.33% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (97.10%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Flag Coverage Δ
compiled 28.11% <0.00%> (-0.07%) ⬇️
unit 97.04% <97.10%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 100.00% <ø> (ø)
console 97.14% <ø> (ø)
dependency_injection 97.98% <ø> (ø)
dotenv 98.58% <ø> (ø)
event_dispatcher 95.49% <ø> (ø)
framework 98.14% <ø> (ø)
image_size 96.64% <ø> (ø)
mercure 95.02% <ø> (ø)
mime 99.42% <ø> (ø)
negotiation 97.94% <ø> (ø)
routing 98.40% <ø> (ø)
serializer 96.54% <ø> (ø)
spec 96.68% <ø> (ø)
validator 95.85% <97.10%> (-0.03%) ⬇️

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit ec54079 into master May 20, 2025
12 of 14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the compound-constraint-test-case branch May 20, 2025 04:13
PallasAthenaie pushed a commit to athena-framework/validator that referenced this pull request May 20, 2025
)

* Fix equality between `AVD::Constraint` instances
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

1 participant