Allow customizing the finished state of an ACON::Helper::ProgressIndicator
#535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/console
that referenced
this pull request
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Previously when an
ACON::Helper::ProcessIndicatorfinished, it would just stop and display on whatever indicator was last displayed. This PR allows customizing it to display a unique character once it's fnished.Changelog
ACON::Helper::ProgressIndicatorBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title