Fix serialization of value when its type is different type than the ivar#514
Merged
Blacksmoke16 merged 2 commits intomasterfrom Feb 4, 2025
Merged
Fix serialization of value when its type is different type than the ivar#514Blacksmoke16 merged 2 commits intomasterfrom
Blacksmoke16 merged 2 commits intomasterfrom
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
❌ Your patch status has failed because the patch coverage (93.33%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/serializer
that referenced
this pull request
Feb 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
The logic was previously assuming the type of the ivar and the type of the value were the same, which could technically not be true when using accessor.
Fixes #513
Changelog
Before merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title