Add and make require_tld: true the default for AVD::Constraints::URL constraint#492
Merged
Blacksmoke16 merged 1 commit intomasterfrom Dec 16, 2024
Merged
Add and make require_tld: true the default for AVD::Constraints::URL constraint#492Blacksmoke16 merged 1 commit intomasterfrom
require_tld: true the default for AVD::Constraints::URL constraint#492Blacksmoke16 merged 1 commit intomasterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Flags with carried forward coverage won't be shown. Click here to find out more.
📢 Thoughts on this report? Let us know! |
PallasAthenaie
pushed a commit
to athena-framework/validator
that referenced
this pull request
Dec 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Add and make
require_tld: truethe default forURLconstraint. This'll technically make the constraint more strict by default, but also more useful for the most common use cases. I.e. ensuringhttps://example.comis valid buthttps://exampleis not.Resolve #439
Changelog
require_tld: truethe default forAVD::Constraints::URLconstraintBefore merging, remember to add the
athena-framework/athenaprefix to the PR number in the PR title