Skip to content

Conversation

@Blacksmoke16
Copy link
Member

Context

Improves the color support for the console component by having more robust checks on if it should be enabled or not.

Changelog

  • More robust console color support logic

Before merging, remember to add the athena-framework/athena prefix to the PR number in the PR title

@Blacksmoke16 Blacksmoke16 added component:console kind:enhancement New functionality to an existing feature labels Dec 15, 2024
@codecov
Copy link

codecov bot commented Dec 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Flag Coverage Δ
compiled 8.13% <0.00%> (-0.01%) ⬇️
unit 92.79% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
clock 98.18% <ø> (ø)
console 92.66% <100.00%> (+0.05%) ⬆️
dependency_injection 64.28% <ø> (ø)
dotenv 96.80% <ø> (ø)
event_dispatcher 82.75% <ø> (ø)
framework 94.27% <ø> (ø)
image_size 95.03% <ø> (ø)
mercure 93.37% <ø> (ø)
negotiation 97.69% <ø> (ø)
routing 92.96% <ø> (ø)
serializer 87.23% <ø> (ø)
spec 93.54% <ø> (ø)
validator 92.37% <ø> (ø)

📢 Thoughts on this report? Let us know!

@Blacksmoke16 Blacksmoke16 merged commit 70ac6ec into master Dec 15, 2024
14 checks passed
@Blacksmoke16 Blacksmoke16 deleted the better-color-support branch December 15, 2024 18:41
PallasAthenaie pushed a commit to athena-framework/console that referenced this pull request Dec 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:console kind:enhancement New functionality to an existing feature

Development

Successfully merging this pull request may close these issues.

2 participants