Be more strict when it comes to resolving interface based services#408
Merged
Blacksmoke16 merged 3 commits intomasterfrom May 4, 2024
Merged
Be more strict when it comes to resolving interface based services#408Blacksmoke16 merged 3 commits intomasterfrom
Blacksmoke16 merged 3 commits intomasterfrom
Conversation
PallasAthenaie
pushed a commit
to athena-framework/dependency-injection
that referenced
this pull request
May 4, 2024
…thena-framework/athena#408) * Ensure un-aliased singly implemented interfaces are not resolved automatically * Ensure `framework` component explicitly aliases interfaces
PallasAthenaie
pushed a commit
to athena-framework/framework
that referenced
this pull request
May 4, 2024
…thena-framework/athena#408) * Ensure un-aliased singly implemented interfaces are not resolved automatically * Ensure `framework` component explicitly aliases interfaces
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When auto wiring service dependencies, if there was only one service that is compatible with a parameter's type restriction, that service would be used. This PR makes this logic a bit more strict by not doing this if the parameter's type restriction is a module, i.e. an interface.
The reasoning for this change is to prevent the surprise error when you define an interface with a single default implementation. When a parameter was typed as this interface, things would work fine. However, if another implementation of that interface was introduced, you would now have an error.
This change forces you to explicitly alias the default implementation, which can most likely be accomplished by simply annotating the default service with
@[ADI::AsAlias].Changes