DnDTabbedPane. Idx for insertion selection fix.#24
Merged
Conversation
Contributor
Author
|
@aterai you will check it when you have time, right? |
Owner
Yes, I will check it from now on as I may have time this weekend. |
aterai
approved these changes
Feb 23, 2024
aterai
left a comment
Owner
There was a problem hiding this comment.
I was able to reproduce the bug in my environment and confirm that the fix works fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello. Thanks for maintaining this repo! I brought two minor improvements for DnDTabbedPane component.
Bug:
Fix:
Previously we checked tab rect by translating it backward by its half. I suggest checking halfs of the rect within original bounds. Explicit check for last tab remains the same, but extended to full width instead of half.