Use QPointer and set flag to delete on close#8
Merged
atari2600tim merged 5 commits intofixComposerCrashfrom Mar 9, 2020
Merged
Use QPointer and set flag to delete on close#8atari2600tim merged 5 commits intofixComposerCrashfrom
atari2600tim merged 5 commits intofixComposerCrashfrom
Conversation
atari2600tim
added a commit
that referenced
this pull request
Mar 14, 2020
* fix segfault with Composer window being left open * Added closeEvent to Composer window which clears pointer to itself in cTelnet when it gets closed without pushing save/cancel (such as clicking X or right-click and close) * Added to cTelnet destructor saying to close Composer window * Use QPointer and set flag to delete on close (#8) * Update dlgComposer.h * Update dlgComposer.cpp * Update ctelnet.cpp * Update ctelnet.h * Update dlgComposer.cpp * missed part (#9) * Update ctelnet.cpp * Update ctelnet.cpp
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.