xpadneo: Remove deprecated ida_simple_xx() usage#566
Closed
orderedstereographic wants to merge 1 commit intoatar-axis:masterfrom
Closed
xpadneo: Remove deprecated ida_simple_xx() usage#566orderedstereographic wants to merge 1 commit intoatar-axis:masterfrom
orderedstereographic wants to merge 1 commit intoatar-axis:masterfrom
Conversation
Update to use ida_alloc() and ida_free() in place of the deprecated ida_simple_get() and ida_simple_remove() calls. Linux has removed this API in the v6.18 release candidates. ida_simple_xx() has been deprecated since v5.10 and the new API was introduced in v4.19. Closes: atar-axis#562
Collaborator
|
Thanks, so we'll need to bump the minimum kernel requirement to 4.19. I have one patch queued around these lines, I'd like to merge those first, then we'll need a rebase of this. |
kakra
added a commit
to kakra/xpadneo
that referenced
this pull request
Nov 7, 2025
Update to use ida_alloc() and ida_free() in place of the deprecated ida_simple_get() and ida_simple_remove() calls. Linux has removed this API in the v6.18 release candidates. ida_simple_xx() has been deprecated since v5.10 and the new API was introduced in v4.19. Co-authored-by: orderedstereographic <161899146+orderedstereographic@users.noreply.github.com> Fixes: atar-axis#562 Closes: atar-axis#566 Signed-off-by: Kai Krakow <kai@kaishome.de>
Collaborator
|
This is in my patch queue to properly merge it with some memory cleanups and bump the minimum version requirement. This PR will be automatically closed once the patches reach master. |
brianmcgillion
added a commit
to brianmcgillion/ghaf
that referenced
this pull request
Dec 4, 2025
atar-axis/xpadneo#566 the version of xpad neo in mainline is still using a deprecated function. That function is now obselete in linux 6.18. Disable until this fix is merged and nixpkgs pulls the latest. Watchers set. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
brianmcgillion
added a commit
to tiiuae/ghaf
that referenced
this pull request
Dec 4, 2025
atar-axis/xpadneo#566 the version of xpad neo in mainline is still using a deprecated function. That function is now obselete in linux 6.18. Disable until this fix is merged and nixpkgs pulls the latest. Watchers set. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
3 tasks
juliuskoskela
pushed a commit
to juliuskoskela/ghaf
that referenced
this pull request
Dec 16, 2025
atar-axis/xpadneo#566 the version of xpad neo in mainline is still using a deprecated function. That function is now obselete in linux 6.18. Disable until this fix is merged and nixpkgs pulls the latest. Watchers set. Signed-off-by: Brian McGillion <bmg.avoin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update to use ida_alloc() and ida_free() in place of the deprecated ida_simple_get() and ida_simple_remove() calls. Linux has removed this API in the v6.18 release candidates. ida_simple_xx() has been deprecated since v5.10 and the new API was introduced in v4.19.
Closes: #562
This change was based on https://lore.kernel.org/all/2ce706d3242b9d3e4b9c20c0a7d9a8afcf8897ec.1729423829.git.christophe.jaillet@wanadoo.fr/ which updated which API was used for a GPIO driver.
I tested the build against 6.18-rc2 and I see no change in behavior when using my controller.