Skip to content

feat: support AsyncAPI spec v3#193

Merged
asyncapi-bot merged 14 commits intoasyncapi:masterfrom
KhudaDad414:support-v3
Dec 19, 2023
Merged

feat: support AsyncAPI spec v3#193
asyncapi-bot merged 14 commits intoasyncapi:masterfrom
KhudaDad414:support-v3

Conversation

@KhudaDad414
Copy link
Member

@KhudaDad414 KhudaDad414 commented Aug 30, 2023 •
edited
Loading

Description:

  • Instead of parsing the components ourselves, it now uses parser-js to parse the components (as it should have from the start )
  • Add debug module and debugging logs.
  • Add a new filter so it doesn't remove components that can be reused.
  • Update parser so it now supports v3 of spec.
  • Update the example so it reads and writes to a file.

Note 1: After merging this PR some components like traits won't be optimised since from this point forward we are not going to parse the AsyncAPI file here, the parser is doing it. (Read more here: asyncapi/parser-api#109)

fixes asyncapi/parser-js#168, fixes asyncapi/parser-js#192, fixes asyncapi/parser-js#173

@KhudaDad414 KhudaDad414 marked this pull request as ready for review September 5, 2023 11:46
@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Sep 5, 2023 •
edited
Loading

@derberg @jonaslagoni would appreciate some feedback. 🙏

@KhudaDad414 KhudaDad414 mentioned this pull request Sep 5, 2023
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Oct 5, 2023

@derberg pingy pongy. 😆

@KhudaDad414 KhudaDad414 changed the title feat: support v3 feat: support AsyncAPI spec v3 Oct 5, 2023
derberg
derberg reviewed Oct 9, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I guess better to wait with merge before changes are done to enable operations under components.

Also maybe this should go out as 1.0

@KhudaDad414 KhudaDad414 mentioned this pull request Dec 18, 2023
Closed
@KhudaDad414 KhudaDad414 requested a review from derberg December 19, 2023 10:57
@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Dec 19, 2023

Also maybe this should go out as 1.0

There are a few more things that need to change for v1. like supporting all components and changing the Report generation format.

@derberg
Copy link
Member

derberg commented Dec 19, 2023

@KhudaDad414 so now there are no breaking changes here? all good working with v2 documents?

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Dec 19, 2023

@derberg yes. it is compatible with v3 and v2.

derberg
derberg previously approved these changes Dec 19, 2023
View reviewed changes
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 19, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@KhudaDad414 KhudaDad414 requested a review from derberg December 19, 2023 15:13
@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Dec 19, 2023

@derberg tests were failing. can you approve it again, please?

derberg
derberg approved these changes Dec 19, 2023
View reviewed changes
Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KhudaDad414
Copy link
Member Author

KhudaDad414 commented Dec 19, 2023

/rtm

@asyncapi-bot asyncapi-bot merged commit bc259ae into asyncapi:master Dec 19, 2023
@asyncapi-bot
Copy link
Contributor

asyncapi-bot commented Dec 19, 2023

🎉 This PR is included in version 0.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derberg derberg derberg approved these changes

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu

@asyncapi-bot-eve asyncapi-bot-eve Awaiting requested review from asyncapi-bot-eve asyncapi-bot-eve is a code owner

Assignees

No one assigned

Labels

released

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Extend the components model with has-like functions

3 participants

@KhudaDad414 @derberg @asyncapi-bot