Skip to content

chore: References resolved wrong when parsing is done inside Promise.all()#168

Merged
derberg merged 2 commits intoasyncapi:masterfrom
derberg:concurency
Aug 31, 2020
Merged

chore: References resolved wrong when parsing is done inside Promise.all()#168
derberg merged 2 commits intoasyncapi:masterfrom
derberg:concurency

Conversation

@derberg
Copy link
Member

@derberg derberg commented Aug 28, 2020

Description

  • References resolved wrong when parsing is done inside Promise.all(). It was caused by the fact that $RefParser was initialized globally and shared in concurrent parsing

@derberg derberg marked this pull request as ready for review August 28, 2020 11:29
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@derberg derberg changed the title fix: References resolved wrong when parsing done inside Promise.all() fix: References resolved wrong when parsing is done inside Promise.all() Aug 28, 2020
@derberg derberg requested a review from fmvilas August 28, 2020 12:02
Copy link

@mauriceackel mauriceackel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@derberg derberg changed the title fix: References resolved wrong when parsing is done inside Promise.all() chore: References resolved wrong when parsing is done inside Promise.all() Aug 31, 2020
@derberg derberg merged commit 8dd702a into asyncapi:master Aug 31, 2020
@derberg derberg deleted the concurency branch August 31, 2020 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants