Always use __dict__ and ignore __slots__ on classes#169
Always use __dict__ and ignore __slots__ on classes#169Nodd wants to merge 2 commits intoastropy:mainfrom
Conversation
|
The workflow failure seems unrelated to my modification. |
Codecov Report
@@ Coverage Diff @@
## main #169 +/- ##
==========================================
+ Coverage 89.83% 89.88% +0.05%
==========================================
Files 27 27
Lines 1141 1137 -4
==========================================
- Hits 1025 1022 -3
+ Misses 116 115 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
This is related though. I'll have to ping @eteq , @jairideout , and @pkgw based on the blame on the affected function. |
|
RTD failure is indeed unrelated. I don't know why it is pulling such old versions. |
I fixed this, but there was another error :
Yeah, I guess the added complexity was there for a reason ? But if |
|
@Nodd , unfortunately I wasn't involved in the original design of the code, so I have no idea what it is trying to do, but hopefully one of the contributors could comment more. 🤞 I Thanks for your contribution and for your patience! |
|
Looks like the rebase went well! |
|
OK, I'll do this as soon as I can find some time. |
|
I ran into this problem as well when attempting to automodapi a module containing some classes that extend pydantic's BaseModel which uses @Nodd can cherry pick the commit with the tests, or I can create a new PR. No preference on my end. |
|
Thanks for your interested in this PR! Since it has been 6 months, if a new PR could be made with cherry picking the original commits here + new stuff needed to push it over the finish line, that would be great! 🙇♀️ |
|
Sorry, I never found the time to finish this. @kylefawcett you can create a new PR, I'll be very happy if you manage to get it done 😃 |
|
Thanks, all! Superseded by #181 |
Updated "Use __dict__ and ignore __slots__ on classes #169
Fix #168