BUG: Handle invalid masked_invalid mask#151
Closed
pllim wants to merge 2 commits intoastropy:mainfrom
Closed
Conversation
Codecov Report
@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 75.46% 75.39% -0.08%
==========================================
Files 9 9
Lines 693 695 +2
==========================================
+ Hits 523 524 +1
- Misses 170 171 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This was referenced Nov 30, 2022
Contributor
|
looks like this change needs some test coverage to made codecov happy... |
Member
Author
|
I don't know how to write that test. Suggestion welcome! |
pllim
added a commit
to pllim/specreduce
that referenced
this pull request
Dec 2, 2022
Member
Author
|
I folded this PR to #153 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I came across this while investigating spacetelescope/jdaviz#1877 .
np.ma.masked_invalid(img).maskcould returnFalse. This is not being recognized byspecutils, which will then emit a confusing message about the mask having mismatch shape().Possible suspects:
mask_invalidconsistent withmask_whereifcopyis set toFalsenumpy/numpy#22046masked_invalidchange. numpy/numpy#22406Also see: