Skip to content

TST: Temporarily ignore AstropyDeprecationWarning#1517

Merged
bsipocz merged 1 commit intoastropy:masterfrom
pllim:no-depre-exc
Aug 1, 2019
Merged

TST: Temporarily ignore AstropyDeprecationWarning#1517
bsipocz merged 1 commit intoastropy:masterfrom
pllim:no-depre-exc

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented Aug 1, 2019

This would allow AstropyDeprecationWarning to exist and not fail other PRs like #1163 until #1508 can be merged after PY2 removal. 😬

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Aug 1, 2019

Yes, I think this is the only way forward. Then add yet more flexibility into astropy core for the future to be able to skip just certain AstropyDeprecationWarnings.

@bsipocz bsipocz added this to the v0.3.10 milestone Aug 1, 2019
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Aug 1, 2019

to skip just certain AstropyDeprecationWarnings

I think allowing it is a slippery slope. Please open an issue with this suggestion over at Astropy core, then we can discuss it.

@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Aug 1, 2019

I think allowing it is a slippery slope. Please open an issue with this suggestion over at Astropy core, then we can discuss it.

currently I'm confused, cannot make warnings_to_ignore_by_pyver work even for normal DeprecationWarning, so I'm sure I do something wrong. Will open an issue once I clear up the situation.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2019

Codecov Report

Merging #1517 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1517   +/-   ##
=======================================
  Coverage   62.61%   62.61%           
=======================================
  Files         174      174           
  Lines       14413    14413           
=======================================
  Hits         9025     9025           
  Misses       5388     5388

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 771e75b...20057dc. Read the comment docs.

@bsipocz bsipocz merged commit 96d0e33 into astropy:master Aug 1, 2019
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented Aug 1, 2019

Thanks @pllim!

@pllim pllim deleted the no-depre-exc branch August 1, 2019 20:31
@pllim
Copy link
Copy Markdown
Member Author

pllim commented Aug 1, 2019

You are welcome. Sorry for the problem!

pllim added a commit to pllim/astroquery that referenced this pull request Aug 1, 2019
@pllim
Undo astropy#1517
9070b2c
@pllim pllim mentioned this pull request Aug 1, 2019
Merged
4 tasks
pllim added a commit to pllim/astroquery that referenced this pull request Aug 2, 2019
@pllim
Move timer functions from astropy.
26d60b6 
Remove f-string for PY2 compat

Undo astropy#1517
pllim added a commit to pllim/astroquery that referenced this pull request Oct 10, 2019
@pllim
Move timer functions from astropy.
a35a954 
Remove f-string for PY2 compat

Undo astropy#1517
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bsipocz bsipocz bsipocz approved these changes

Assignees

No one assigned

Labels

infrastructure merge-when-ci-passes no-changelog-entry-needed

Projects

None yet

Milestone

v0.3.10

Development

Successfully merging this pull request may close these issues.

2 participants

@pllim @bsipocz