Skip to content

Change mention of conda (was: change conda to miniforge)#617

Merged
pllim merged 3 commits into
astropy:mainfrom
eteq:update-install
Sep 23, 2024
Merged

Change mention of conda (was: change conda to miniforge)#617
pllim merged 3 commits into
astropy:mainfrom
eteq:update-install

Conversation

@eteq

@eteq eteq commented Sep 6, 2024

Copy link
Copy Markdown
Member

This is really just a companion to astropy/astropy#16555 to synchronize what's on the web site with whatever that settles on. Please have discussion about what we should actually recommend in astropy/astropy#16555 so that we don't spread it around multiple threads.

Rendered doc: https://output.circle-artifacts.com/output/job/fc974b2f-31be-45e0-a824-116fb2da9647/artifacts/0/html/index.html

@pllim pllim left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astropy/astropy#16555 was superseded by astropy/astropy#16987 and I don't see any usage of miniforge install over there.

Comment thread index.html Outdated
@bsipocz

bsipocz commented Sep 18, 2024

Copy link
Copy Markdown
Member

I don't see any usage of miniforge install over there.

That is a very very unfortunate outcome. Switching from conda to miniforge was a clear recommendation coming out of the NF summit. Those PRs ended up in the usual bikeshedding of pip vs conda for experienced developers, and neither should those POVs drive the end-user recommendations, and IMO more modern tools should be taken into account (I'm thinking of pixi) even if core developers stay on using their own preferences due to muscle memory).

So, I'm with @eteq here and strongly suggest ditching conda in favour of miniforge (even though my own bikeshed is pip-coloured).

Never mind my comment, the install page indeed ditched miniconda for miniforge, so the actual conda command is ru from the right place. And it's just an unfortunate side effect that the commands look the same but the configs are different.

So, my comment for this section would be to fully get rid of it; and only point to the install guide in the docs as there isn't enough space to go into the nuances between conda install and conda install...

as suggested by bsipocz
@pllim

pllim commented Sep 18, 2024

Copy link
Copy Markdown
Member

I took the liberty to push a follow-up commit here in response to review from @bsipocz . Hope you don't mind, @eteq !

Does it look less confusing now?

@pllim pllim changed the title change conda to miniforge Remove mention of conda (was: change conda to miniforge) Sep 18, 2024
Comment thread index.html Outdated
Comment thread index.html
If instead you normally use <code>conda</code>, you can do:
<p/><pre>conda install -c conda-forge astropy</pre>
or using <code>update</code> instead of <code>install</code> if <code>astropy</code> is already installed.
The astropy core package is also available in a number of other package managers, so be sure to check your preferred one!

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status of "other package managers"? Is this now just Debian-based linux package managers? AFAIK we no longer support any Mac package managers.

@pllim pllim Sep 19, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once in a while, we get issues from random distros (e.g., astropy/astropy#14166) so they are out there even if we might not be aware.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@taldcroft , just fyi: Red Hat and Arch also package astropy (https://rpmfind.net/linux/rpm2html/search.php?query=python-astropy and https://archlinux.org/packages/extra/x86_64/python-astropy/), but they're basically just silently working (I can speak for the Arch one at least, which has worked perfectly for ~4 years.)

Comment thread index.html Outdated
Co-authored-by: Tom Aldcroft <taldcroft@gmail.com>
@pllim pllim changed the title Remove mention of conda (was: change conda to miniforge) Change mention of conda (was: change conda to miniforge) Sep 19, 2024
@pllim

pllim commented Sep 19, 2024

Copy link
Copy Markdown
Member

Thanks for the review, @taldcroft ! I accepted all your suggestions.

@pllim

pllim commented Sep 23, 2024

Copy link
Copy Markdown
Member

@taldcroft , what do you think? Good to merge?

@taldcroft taldcroft left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@pllim

pllim commented Sep 23, 2024

Copy link
Copy Markdown
Member

@bsipocz , conda install instruction is gone. Can you please re-review as well. Thanks!

@pllim pllim requested a review from bsipocz September 23, 2024 19:59

@bsipocz bsipocz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good now.

@pllim pllim merged commit 70fcc19 into astropy:main Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants