Skip to content

migrating APE1 to git, with changes to reflect use of git instead of the...#1

Merged
eteq merged 10 commits into
astropy:masterfrom
perrygreenfield:master
Nov 8, 2013
Merged

migrating APE1 to git, with changes to reflect use of git instead of the...#1
eteq merged 10 commits into
astropy:masterfrom
perrygreenfield:master

Conversation

@perrygreenfield

Copy link
Copy Markdown
Member

here it is

@astrofrog

Copy link
Copy Markdown
Member

@perrygreenfield - could you wrap the text? At the moment, it will be hard to comment on in the git diff view. Thanks!

@keflavich

Copy link
Copy Markdown
Contributor

Did the text wrapping fail? It looks like the "underline" lines are not underlining, e.g.:

header ------

instead of

header
---------

(see https://github.com/perrygreenfield/astropy-APEs/blob/60eb1df282718b52c85f7f248be674c4ba4d89d6/APE1.rst )

@perrygreenfield

Copy link
Copy Markdown
Member Author

Well, I'd say the wrapping had unconsidered side effects. Let me fix that.

On Nov 8, 2013, at 10:57 AM, Adam Ginsburg wrote:

Did the text wrapping fail? It looks like the "underline" lines are not underlining, e.g.:

header ------

instead of

header

(see https://github.com/perrygreenfield/astropy-APEs/blob/60eb1df282718b52c85f7f248be674c4ba4d89d6/APE1.rst )


Reply to this email directly or view it on GitHub.

Comment thread APE1.rst Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I don't think this step is necessary. I think it's fine to say the procedure is just:

  • Get opinions on astropy-dev, make sure it seems like something APE-able.
  • Issue a PR on astropy-APEs, and post on astropy-dev that the APE exists.

That is, mostly remove this paragraph, but add a mention in the second paragraph that when the PR to astropy-APEs is issued, they must post to astropy-dev that it exists.

Otherwise, there's two different media for the APE - one copy on the mailing list and another on github, and it'll be difficult to keep track when something gets updated, as that isn't reflected in the mailing list copy.

@eteq

eteq commented Nov 8, 2013

Copy link
Copy Markdown
Member

I made a few changes in perrygreenfield#1 - if you merge that it should appear here.

@eteq

eteq commented Nov 8, 2013

Copy link
Copy Markdown
Member

Looks good to me now - are there any other things you had pending, @perrygreenfield, or should we merge this?

@perrygreenfield

Copy link
Copy Markdown
Member Author

looks good to merge

eteq added a commit that referenced this pull request Nov 8, 2013
@eteq eteq merged commit 236f867 into astropy:master Nov 8, 2013
@eteq

eteq commented Nov 8, 2013

Copy link
Copy Markdown
Member

done - first APE merged!

astrofrog pushed a commit that referenced this pull request Feb 19, 2021
Grammar and Style Edits to APE0.rst
nden pushed a commit to nden/astropy-APEs that referenced this pull request Mar 12, 2022
kbwestfall pushed a commit that referenced this pull request Jan 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants