Skip to content

Update header when creating GroupsHDU from data#9216

Merged
saimn merged 3 commits intoastropy:masterfrom
saimn:groups
Sep 10, 2019
Merged

Update header when creating GroupsHDU from data#9216
saimn merged 3 commits intoastropy:masterfrom
saimn:groups

Conversation

@saimn
Copy link
Contributor

@saimn saimn commented Sep 9, 2019

Fix #9193, which was caused by #8563 (my bad!).

And while reading the docs I also fixed some minor issues mentioning the wrong group number/name (following changes in bf54179).

@saimn saimn added the io.fits label Sep 9, 2019
@saimn saimn added this to the v3.2.2 milestone Sep 9, 2019
@saimn saimn requested a review from MSeifert04 September 9, 2019 20:31
@pllim
Copy link
Member

pllim commented Sep 9, 2019

cc @kazuakiyama

Copy link
Contributor

@MSeifert04 MSeifert04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@saimn
Copy link
Contributor Author

saimn commented Sep 10, 2019

Thanks for the review @MSeifert04 , let's merge then.

@saimn saimn merged commit e0caf54 into astropy:master Sep 10, 2019
@saimn saimn deleted the groups branch September 10, 2019 20:57
bsipocz pushed a commit that referenced this pull request Sep 14, 2019
Update header when creating GroupsHDU from data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An issue in the HDU header information created by astropy.io.fits.GroupsHDU seen at least after v3.2.1

3 participants