Add test to create table from list of rows#9052
Merged
mhvk merged 1 commit intoastropy:masterfrom Jul 26, 2019
Merged
Conversation
mhvk
approved these changes
Jul 26, 2019
Contributor
mhvk
left a comment
There was a problem hiding this comment.
Thanks, looks good. Note that numpy-dev fails because the change was reverted only for 1.17, not for numpy-dev itself. I still think it is good to get this test in, so will approve and merge. We now have time to fix the problem on our side (or maybe it will go away when things are restructured in numpy)
bsipocz
pushed a commit
that referenced
this pull request
Aug 1, 2019
Add test to create table from list of rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #8976 , cc @duncanmmacleod
xref #8976 (comment)
Note for reviewer: Check the numpy-dev job on Travis, which is allowed to fail.