Skip to content

TST: Revert mpl-dev xfail due to upstream patch#8757

Merged
bsipocz merged 1 commit intoastropy:masterfrom
pllim:revert-8696
May 24, 2019
Merged

TST: Revert mpl-dev xfail due to upstream patch#8757
bsipocz merged 1 commit intoastropy:masterfrom
pllim:revert-8696

Conversation

@pllim
Copy link
Copy Markdown
Member

@pllim pllim commented May 24, 2019

Revert #8696 due to upstream patch at matplotlib/matplotlib#14216 . Fix #8678 .

@pllim
Copy link
Copy Markdown
Member Author

pllim commented May 24, 2019

Yay, mpldev job passed!

@bsipocz bsipocz merged commit d4e4e1c into astropy:master May 24, 2019
@bsipocz
Copy link
Copy Markdown
Member

bsipocz commented May 24, 2019

Thanks @pllim. Changes seem trivial, so no need to wait for more review.

@codecov
Copy link
Copy Markdown

codecov bot commented May 24, 2019

Codecov Report

Merging #8757 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8757      +/-   ##
==========================================
+ Coverage   86.97%   86.97%   +<.01%     
==========================================
  Files         399      399              
  Lines       59382    59382              
  Branches     1100     1100              
==========================================
+ Hits        51648    51649       +1     
+ Misses       7093     7092       -1     
  Partials      641      641
Impacted Files Coverage Δ
astropy/samp/hub.py 77.52% <0%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 51db6a6...76035ec. Read the comment docs.

@pllim pllim deleted the revert-8696 branch May 24, 2019 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TST: image-tests-mpldev is failing

2 participants