Try to ensure we get fewer deprecationwarnings from comparisons.#8755
Merged
pllim merged 2 commits intoastropy:masterfrom May 24, 2019
Merged
Try to ensure we get fewer deprecationwarnings from comparisons.#8755pllim merged 2 commits intoastropy:masterfrom
pllim merged 2 commits intoastropy:masterfrom
Conversation
Member
|
@mhvk , catching all the warnings is not critical, so we can defer to a follow-up PR if needed. Thanks for the quick fix! |
Codecov Report
@@ Coverage Diff @@
## master #8755 +/- ##
==========================================
- Coverage 86.97% 86.97% -0.01%
==========================================
Files 399 399
Lines 59384 59382 -2
Branches 1100 1100
==========================================
- Hits 51652 51648 -4
- Misses 7091 7093 +2
Partials 641 641
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #8755 +/- ##
==========================================
- Coverage 86.97% 86.97% -0.01%
==========================================
Files 399 399
Lines 59384 59382 -2
Branches 1100 1100
==========================================
- Hits 51652 51648 -4
- Misses 7091 7093 +2
Partials 641 641
Continue to review full report at Codecov.
|
bsipocz
pushed a commit
that referenced
this pull request
May 27, 2019
Try to ensure we get fewer deprecationwarnings from comparisons.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is all a bit tricky to get right, but the extra tests should help. @pllim - is it useful to explicitly ensure we don't get
DeprecationWarning, as I do here? Or shall we leave that to your PR?fixes #8752