Move periodogram classes to astropy.timeseries#8591
Merged
bsipocz merged 14 commits intoastropy:masterfrom Apr 19, 2019
Merged
Conversation
df1a1d2 to
537fa03
Compare
537fa03 to
21503c1
Compare
Codecov Report
@@ Coverage Diff @@
## master #8591 +/- ##
==========================================
- Coverage 86.89% 86.88% -0.02%
==========================================
Files 393 396 +3
Lines 58653 59590 +937
Branches 1064 1238 +174
==========================================
+ Hits 50969 51774 +805
- Misses 7065 7143 +78
- Partials 619 673 +54
Continue to review full report at Codecov.
|
6ead8c0 to
3d135a3
Compare
bsipocz
reviewed
Apr 18, 2019
| astropy.stats | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| - The ``BoxLeastSquares`` and ``LombScargle`` classes have been moved to the |
Member
There was a problem hiding this comment.
add an entry about the move under astropy.timeseries, too.
Member
There was a problem hiding this comment.
I can't see it here, I suppose it lost somewhere during rebase.
44ce18f to
b471b19
Compare
f25e444 to
98bb91a
Compare
98bb91a to
218a128
Compare
pllim
reviewed
Apr 19, 2019
Member
pllim
left a comment
There was a problem hiding this comment.
Overall, looks good. Some minor comments below.
eteq
approved these changes
Apr 19, 2019
Member
|
There is a conflict now, please rebase. |
Co-Authored-By: astrofrog <thomas.robitaille@gmail.com>
6951e1f to
2af4ee9
Compare
bsipocz
approved these changes
Apr 19, 2019
| astropy.stats | ||
| ^^^^^^^^^^^^^ | ||
|
|
||
| - The ``BoxLeastSquares`` and ``LombScargle`` classes have been moved to the |
Member
There was a problem hiding this comment.
I can't see it here, I suppose it lost somewhere during rebase.
Member
Author
Member
|
(I was waiting for the |
Member
Member
|
All green, so I go ahead and merge now. Thanks @astrofrog! |
9 tasks
eerovaher
added a commit
to eerovaher/astropy
that referenced
this pull request
Oct 25, 2023
In astropy#8591 classes implementing box least squares and Lomb-Scargle periodograms were moved from `astropy.stats` to `astropy.timeseries`. Importing them from `stats` has been deprecated for long enough.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up to #8540. The intent has always been to eventually move the periodogram algorithms to astropy.timeseries once that module existed, so here we go. For now I've only moved the classes, but I plan to make them integrate better with the
TimeSeriesclass. This is going to require a bit more intricate work, so in the interest of making sure that we get the classes moved for 3.2, and to keep things easier to review, I'll do the further integration work in a separate PR. So this PR is ready for review once rebased.Fixes #8410