Skip to content

Fix Moffat1D and Moffat2D derivatives. [#8094]#8108

Merged
nden merged 1 commit into
astropy:masterfrom
ycopin:Issue8094
Nov 25, 2018
Merged

Fix Moffat1D and Moffat2D derivatives. [#8094]#8108
nden merged 1 commit into
astropy:masterfrom
ycopin:Issue8094

Conversation

@ycopin

@ycopin ycopin commented Nov 10, 2018

Copy link
Copy Markdown
Contributor

fixes #8094

@astropy-bot

astropy-bot Bot commented Nov 10, 2018

Copy link
Copy Markdown

Check results are now reported in the status checks at the bottom of this page.

@codecov

codecov Bot commented Nov 10, 2018

Copy link
Copy Markdown

Codecov Report

Merging #8108 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #8108      +/-   ##
==========================================
+ Coverage   86.92%   86.92%   +<.01%     
==========================================
  Files         383      383              
  Lines       57821    57822       +1     
  Branches     1056     1056              
==========================================
+ Hits        50262    50263       +1     
  Misses       6945     6945              
  Partials      614      614
Impacted Files Coverage Δ
astropy/modeling/functional_models.py 96.39% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c29ecd...83412a2. Read the comment docs.

@bsipocz bsipocz added this to the 3.1.1 milestone Nov 10, 2018
@bsipocz bsipocz requested review from adonath and nden November 10, 2018 19:11
@bsipocz

bsipocz commented Nov 10, 2018

Copy link
Copy Markdown
Member

This will definitely need tests, or fixes to the current tests to make them fail on the previous version.

@nden

nden commented Nov 13, 2018

Copy link
Copy Markdown
Contributor

Thanks @ycopin ! I will be able to look at this in a couple of days.

@nden nden left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @ycopin !

@nden

nden commented Nov 25, 2018

Copy link
Copy Markdown
Contributor

@bsipocz I think this is failing because there's no section for 3.1.1 in CHANGES. How should this be handled? Should I make one?

@nden

nden commented Nov 25, 2018

Copy link
Copy Markdown
Contributor

I think the tests for derivatives did not fail because of the specific values used in the tests - gamma=1, x_0=0, y_0=0. While those tests are OK, we should add a more general one.

@bsipocz

bsipocz commented Nov 25, 2018

Copy link
Copy Markdown
Member

@nden - don't worry about the changelog, I'll sort it out once the release is really out. Since this is a bugfix, I suppose it can land in RC2 once you merge it.

@nden

nden commented Nov 25, 2018

Copy link
Copy Markdown
Contributor

I guess the bot is then confused because there is a changelog entry and it has the correct PR number.

@bsipocz bsipocz modified the milestones: 3.1.1, v3.1 Nov 25, 2018
@bsipocz

bsipocz commented Nov 25, 2018

Copy link
Copy Markdown
Member

The PR number in the changelog is incorrect (it has to be the PR's number not the issue's it fixes), but I can fix it while doing the release, feel free to merge whenever this is ready.

@ycopin

ycopin commented Nov 25, 2018

Copy link
Copy Markdown
Contributor Author

@nden thanks for the review.

To test the derivatives, 0s and 1s are always susceptible to be special values... Just systematically take 0.5 or 2 or whatever else!

@nden nden merged commit 98771ac into astropy:master Nov 25, 2018
@nden nden mentioned this pull request Nov 25, 2018
bsipocz pushed a commit that referenced this pull request Nov 28, 2018
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [#8094]
nden added a commit to nden/astropy that referenced this pull request May 3, 2019
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [astropy#8094]

(cherry picked from commit 98771ac)
nden added a commit to nden/astropy that referenced this pull request May 24, 2019
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [astropy#8094]

(cherry picked from commit 98771ac)
@ycopin ycopin deleted the Issue8094 branch October 4, 2019 09:14
chris-simpson added a commit to chris-simpson/astropy that referenced this pull request Sep 29, 2020
chris-simpson added a commit to chris-simpson/astropy that referenced this pull request Sep 30, 2020
chris-simpson added a commit to chris-simpson/astropy that referenced this pull request Sep 30, 2020
nden added a commit that referenced this pull request Oct 5, 2020
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
astrofrog pushed a commit that referenced this pull request Oct 6, 2020
eteq pushed a commit to eteq/astropy that referenced this pull request Oct 12, 2020
eteq pushed a commit that referenced this pull request Oct 13, 2020
yoachim pushed a commit to yoachim/astropy that referenced this pull request Oct 23, 2020
namurphy pushed a commit to namurphy/astropy that referenced this pull request Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moffat1D and Moffat2D derivatives

3 participants