Fix Moffat1D and Moffat2D derivatives. [#8094]#8108
Conversation
|
Check results are now reported in the status checks at the bottom of this page. |
Codecov Report
@@ Coverage Diff @@
## master #8108 +/- ##
==========================================
+ Coverage 86.92% 86.92% +<.01%
==========================================
Files 383 383
Lines 57821 57822 +1
Branches 1056 1056
==========================================
+ Hits 50262 50263 +1
Misses 6945 6945
Partials 614 614
Continue to review full report at Codecov.
|
|
This will definitely need tests, or fixes to the current tests to make them fail on the previous version. |
|
Thanks @ycopin ! I will be able to look at this in a couple of days. |
|
@bsipocz I think this is failing because there's no section for 3.1.1 in |
|
I think the tests for derivatives did not fail because of the specific values used in the tests - |
|
@nden - don't worry about the changelog, I'll sort it out once the release is really out. Since this is a bugfix, I suppose it can land in RC2 once you merge it. |
|
I guess the bot is then confused because there is a changelog entry and it has the correct PR number. |
|
The PR number in the changelog is incorrect (it has to be the PR's number not the issue's it fixes), but I can fix it while doing the release, feel free to merge whenever this is ready. |
|
@nden thanks for the review. To test the derivatives, 0s and 1s are always susceptible to be special values... Just systematically take 0.5 or 2 or whatever else! |
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [#8094]
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [astropy#8094] (cherry picked from commit 98771ac)
Fix ``Moffat1D`` and ``Moffat2D`` derivatives. [astropy#8094] (cherry picked from commit 98771ac)
undoes part of #8108 that was incorrect
undoes part of #8108 that was incorrect
undoes part of #8108 that was incorrect
undoes part of astropy#8108 that was incorrect
undoes part of #8108 that was incorrect
fixes #8094