TST: Ignore coordinates test warnings#7989
Conversation
|
Hi there @pllim 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labeled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃. Everything looks good from my point of view! 👍 If there are any issues with this message, please report them here. |
This comment has been minimized.
This comment has been minimized.
|
OK, no more dubious year warnings. Hopefully the remaining ones are legit. |
Codecov Report
@@ Coverage Diff @@
## master #7989 +/- ##
==========================================
+ Coverage 86.92% 86.92% +<.01%
==========================================
Files 383 383
Lines 57824 57829 +5
Branches 1056 1056
==========================================
+ Hits 50263 50268 +5
Misses 6947 6947
Partials 614 614
Continue to review full report at Codecov.
|
90fedf4 to
a729448
Compare
|
@mhvk, I think I addressed your comments. Thanks! |
|
@bsipocz , if you think it is still good for 2.0.10, feel free to remilestone (I moved it as not wanting to hold up RC). Thanks! |
TST: Ignore coordinates test warnings
TST: Ignore coordinates test warnings
This PR gets rid of most of the warnings seen when removing
addopts = -p no:warningsinsetup.cfgand then runningpython setup.py test -P coordinates --remote-data.These still exist because I am not sure how to handle them:
ImportWarningthat is probably same as ImportError in Python 3.6 importlib #6025rewarning from FutureWarning: split() requires a non-empty pattern match scientific-python/pytest-doctestplus#29ResourceWarningas reported in TST: --open-files did not catch ResourceWarning #7913 (comment)Also see #7928